Conversation
…tions setup-beam's problem matchers were promoting compiler warnings from third-party deps (postgrex/rewrite's deprecated `xref: [exclude: ...]`, yamerl's deprecated `catch ...` syntax) into GitHub Actions annotations on every build. All three are already at their latest published Hex versions, so there's no fix to bump to - just noise from code we don't own. disable_problem_matchers: true silences the annotation promotion while leaving the actual compiler output in the raw logs. The remaining Node.js 20 deprecation annotation (mlugg/setup-zig@v2.2.1) is not fixable here either - we're already on that action's latest release, and its action.yml still declares `using: 'node20'`; that's upstream-only until they bump it. Closes #9. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces GitHub Actions annotation noise by disabling erlef/setup-beam@v1 problem matchers so that third-party dependency compiler warnings remain in raw logs without being promoted to workflow annotations, addressing issue #9’s dep-warning clutter.
Changes:
- Set
disable_problem_matchers: trueon theerlef/setup-beam@v1step in the main CI workflow. - Set
disable_problem_matchers: trueon theerlef/setup-beam@v1steps in both jobs of the Burrito release workflow. - Add inline documentation explaining why the matchers are disabled and linking to #9.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Disables setup-beam problem matchers to prevent dependency warnings from becoming CI annotations. |
| .github/workflows/burrito-release.yaml | Applies the same matcher-disable setting to both release jobs to keep release pipeline annotations clean. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9 (partially - see caveat below).
erlef/setup-beam@v1registers GitHub Actions problem matchers by default (disable_problem_matchers: false), which scan mix/erlc compiler output and promote matching lines into annotations. That's what was turning postgrex/rewrite's deprecatedxref: [exclude: ...]and yamerl's deprecatedcatch ...syntax - both harmless compiler warnings from third-party deps - into annotation clutter on every build.postgrex,rewrite,yamerl) are already at their latest published Hex versions (verified viamix hex.outdated --all), so there's no version bump that fixes the underlying warnings - they're upstream-only until those maintainers migrate. Settingdisable_problem_matchers: trueon all threeerlef/setup-beam@v1steps (ci.yaml, both jobs inburrito-release.yaml) silences the annotation promotion while leaving the actual compiler output visible in the raw logs.Caveat: the Node.js 20 deprecation annotation (
mlugg/setup-zig@v2.2.1) is not addressed by this PR - we're already pinned to that action's latest release (v2.2.1), and itsaction.ymlstill declaresusing: 'node20'. That's on the action's maintainer to fix; nothing to change here until they bump it.Test plan
ruby -ryaml)mix hex.outdated --allthat postgrex/rewrite/yamerl/yaml_elixir are all already at their latest Hex-published versions - the warnings aren't from us being behindmlugg/setup-zig's latest release (v2.2.1) still targetsnode20in its ownaction.yml- not fixable by re-pinning🤖 Generated with Claude Code