✅ Fix simplecov upgrade#721
Open
nevans wants to merge 3 commits into
Open
Conversation
`joshmfrankel/simplecov-check-action` is broken with simplecov v1.0. And simplecov v1.0 also added a new way to handle minimum coverage requirements. So I've taken this opportunity to ratchet up all of the minimum requirements.
nevans
force-pushed
the
fix-simplecov-upgrade
branch
from
July 22, 2026 17:59
10f5371 to
39a267f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few issues that came from upgrading to v1.0 (in #718), one of which was identified by #717, but I didn't notice those issues until after merging both. Oops!
This updates the simplecov config in several ways:
Maybe a future PR will bring back something similar to
joshmfrankel/simplecov-check-action, but this should be good enough for now.