tests: fix CI warning and distcheck failures - #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-WerrorWhy
The first GitHub Actions run exposed a long-standing invalid
sizeofcalculation and adistcheckfailure caused by distributing thechk_versionexecutable target.Validation
autoreconf -fvi./configuremake check(17 tests)make distcheckSummary by cubic
Fixes CI compile warnings and distcheck failures by correcting the array-length macro and distributing only shell test drivers. Also aligns test naming with rsyslog’s test-group convention and keeps
chk_versionout of the source tarball.NELEMto usesizeof((x)[0])so modern compilers don’t warn under-Werror.TESTSintoTESTS_DEFAULTand limitedEXTRA_DISTto shell test drivers; exclude check programs likechk_versionso they build in distcheck.Written for commit 1b6be54. Summary will update on new commits.