Skip to content

tests: fix CI warning and distcheck failures - #176

Merged
rgerhards merged 1 commit into
masterfrom
codex/ci-cleanup
Jul 23, 2026
Merged

tests: fix CI warning and distcheck failures#176
rgerhards merged 1 commit into
masterfrom
codex/ci-cleanup

Conversation

@rgerhards

@rgerhards rgerhards commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • correct the test array-length macro so modern compilers do not reject it under -Werror
  • keep executable test programs out of the source-distribution file list
  • use rsyslog's named test-group convention for the distributed shell test drivers

Why

The first GitHub Actions run exposed a long-standing invalid sizeof calculation and a distcheck failure caused by distributing the chk_version executable target.

Validation

  • autoreconf -fvi
  • ./configure
  • make check (17 tests)
  • make distcheck

Summary by cubic

Fixes CI compile warnings and distcheck failures by correcting the array-length macro and distributing only shell test drivers. Also aligns test naming with rsyslog’s test-group convention and keeps chk_version out of the source tarball.

  • Bug Fixes
    • Corrected NELEM to use sizeof((x)[0]) so modern compilers don’t warn under -Werror.
    • Split TESTS into TESTS_DEFAULT and limited EXTRA_DIST to shell test drivers; exclude check programs like chk_version so they build in distcheck.
    • Adopted rsyslog-style named test-group convention for distributed shell test drivers.

Written for commit 1b6be54. Summary will update on new commits.

Review in cubic

@rgerhards rgerhards self-assigned this Jul 23, 2026
@rgerhards rgerhards added this to the 0.99.9 milestone Jul 23, 2026
@rgerhards
rgerhards marked this pull request as ready for review July 23, 2026 09:09
@rgerhards
rgerhards merged commit aa8e726 into master Jul 23, 2026
20 checks passed
@rgerhards
rgerhards deleted the codex/ci-cleanup branch July 23, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant