Skip to content

Clarify CSS length inputs in layout docs#1324

Merged
gadenbuie merged 3 commits into
rstudio:mainfrom
LeonidasZhak:codex/clarify-layout-css-lengths
Jul 16, 2026
Merged

Clarify CSS length inputs in layout docs#1324
gadenbuie merged 3 commits into
rstudio:mainfrom
LeonidasZhak:codex/clarify-layout-css-lengths

Conversation

@LeonidasZhak

Copy link
Copy Markdown
Contributor

Closes #1300.

This updates the layout_columns() and layout_column_wrap() documentation to avoid the confusing "CSS length unit" phrasing and gives concrete examples for accepted CSS length values, including numeric pixel values, unit-bearing strings, percentages, and calc() expressions.

Checks run locally:

  • Rscript -e "tools::checkRd("man/layout_columns.Rd"); tools::checkRd("man/layout_column_wrap.Rd")"
  • git diff --check
  • R CMD build --no-build-vignettes .

@CLAassistant

CLAassistant commented Jun 6, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@LeonidasZhak

Copy link
Copy Markdown
Contributor Author

CLA signed, thanks

@LeonidasZhak
LeonidasZhak force-pushed the codex/clarify-layout-css-lengths branch from d88e1ab to a53e537 Compare July 16, 2026 15:54
@LeonidasZhak

Copy link
Copy Markdown
Contributor Author

Updated this PR onto the current main, preserving the new offcanvas NEWS entry alongside the documentation note. Validation: both Rd files pass tools::checkRd(), R CMD build --no-build-vignettes succeeds, and R CMD check completes with Status: OK when unavailable Suggests are not forced.

Comment thread NEWS.md Outdated

@gadenbuie gadenbuie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonidasZhak! I'll take it from here and make sure CI passes before merging 😄

@gadenbuie
gadenbuie merged commit 0122adb into rstudio:main Jul 16, 2026
11 of 12 checks passed
@gadenbuie gadenbuie mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: unclear what a "CSS length unit" is

3 participants