feat(card): Report full screen state as a Shiny input#1006
Merged
Conversation
gadenbuie
changed the base branch from
card/fix-fullscreen-exit-by-removal
to
main
March 12, 2024 15:20
2 tasks
cpsievert
changed the base branch from
main
to
card/fix-fullscreen-exit-by-removal
March 12, 2024 19:40
Collaborator
Please do rebase off main as I have more reservations about that PR. |
cpsievert
reviewed
Mar 12, 2024
cpsievert
reviewed
Mar 12, 2024
gadenbuie
force-pushed
the
card/shiny-input-full-screen
branch
from
March 13, 2024 02:07
a852d27 to
4fac944
Compare
gadenbuie
force-pushed
the
card/shiny-input-full-screen
branch
from
March 13, 2024 02:09
4fac944 to
10db8b2
Compare
gadenbuie
changed the base branch from
card/fix-fullscreen-exit-by-removal
to
main
March 13, 2024 02:11
gadenbuie
force-pushed
the
card/shiny-input-full-screen
branch
from
March 13, 2024 02:15
10db8b2 to
d838ccb
Compare
gadenbuie
marked this pull request as ready for review
March 13, 2024 14:33
cpsievert
reviewed
Mar 13, 2024
cpsievert
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #962
When
card()is given anid, e.g.card(id = "my_card"), the full screen state of the card is now reported asinput$my_card$full_screen.Note: this PR builds on #1005 but could be rebased on
mainto decouple.Example