Skip to content

Added JF test + test dep (i guess i forgot?). Also formats on 2.12. - #60

Merged
rsenne merged 3 commits into
mainfrom
#add-julia-formatter
Jul 27, 2026
Merged

Added JF test + test dep (i guess i forgot?). Also formats on 2.12.#60
rsenne merged 3 commits into
mainfrom
#add-julia-formatter

Conversation

@rsenne

@rsenne rsenne commented Jul 27, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 27, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rsenne

rsenne commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

@penelopeysm 2.10 is stable yeah?

@penelopeysm

Copy link
Copy Markdown
Contributor

You might like to use 2.12 to get this https://github.com/JuliaEditorSupport/JuliaFormatter.jl/releases#release-v2.12.0 change, and also I would add more options to your JuliaFormatter.toml https://juliaeditorsupport.github.io/JuliaFormatter.jl/stable/status/#Update-25-June-2026 otherwise there can be cases where you need to format twice for it to reach a fixed point, but otherwise yeah it's unlikely that the core Blue style will change very much going forward in v2

@rsenne

rsenne commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

So we beat on, pull requests against the quota, borne back ceaselessly into manual review.

@rsenne

rsenne commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

ah great, thanks for the tips!

@rsenne rsenne changed the title Added JF test + test dep (i guess i forgot?). Also formats on 2.10. Added JF test + test dep (i guess i forgot?). Also formats on 2.12. Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (3f0517c) to head (dfe8a0b).

❌ Your project check has failed because the head coverage (89.99%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files           7        7           
  Lines        1069     1069           
=======================================
  Hits          962      962           
  Misses        107      107           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rsenne
rsenne merged commit 654a7b5 into main Jul 27, 2026
5 of 6 checks passed
@rsenne
rsenne deleted the #add-julia-formatter branch July 27, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants