Wire EBI+ map score into titration + pca_optimization aggregate step#16
Merged
Conversation
Adds the EBI+ metric (phenotypic_ebi_plus, ops_utils) everywhere EBI and distinctiveness are currently measured: - titration: METRICS/colors/labels, _score_all_metrics, columns, log line - pca_optimization aggregate step: - per-reporter scoring (aggregation.py) + group_reporter_ebi_plus_raw.csv - new _score_ebi_plus (embeddings.py): CSV + volcano plot - both 1st- and 2nd-pass call sites (phase2.py) + metric violins EBI+ is measured/reported only; it is deliberately NOT added to the consensus PCA-threshold selection formula (sweep_core.py) since that would change feature selection and invalidate existing runs. Requires ops_utils feat/ebi-plus-map-score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the new EBI+ map score into the scoring pipelines
Consumer of the new
phenotypic_ebi_plusmetric (ops_utils PR: czbiohub-sf/ops_utils#23 — must merge together; this branch depends on it).EBI+ = guide-level distinctiveness where the positive group is the gene's EBI complex (else the gene itself); non-complex genes reduce to distinctiveness, complex members collapse into one group.
Added everywhere EBI / distinctiveness is measured
METRICS, colors, labels,_score_all_metrics, output columns, log line. Addingebi_plustoMETRICSauto-invalidates cached titration CSVs (same mechanism as when EBI was added), so markers re-score to pick it up.aggregation.py): scalar + df +pca_report.csvcolumns +group_reporter_ebi_plus_raw.csvmatrix + log_score_ebi_plus(embeddings.py): writesphenotypic_ebi_plus.csv+ volcano plotphase2.py) + metric violinsDeliberately NOT changed
EBI+ is measured/reported only. It is not added to the consensus PCA-threshold selection formula (
sweep_core.py), because that changes which features get selected and would invalidate existing runs — left as an explicit opt-in.Ran on paper_v2 cell_dino (56 markers, per-guide-median titration): all reporters produce EBI+ columns and plots.
Attempts at a new map score — kept isolated from the
diffex-interpretabilitybranch (branched offmain).