Do not install python3-pytest-asyncio on humble

[Ryan4253]

Description

As title. Fixes #884

Is this user-facing behavior change?

Yes, CI stops breaking in rclpy

Did you use Generative AI?

No

Additional Information

Docker-RHEL is not modified since python3-pytest-asyncio is already gated by RHEL>9 and Humble uses RHEL8

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[Ryan4253]

@Mergifyio queue

[mergify]

queue

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details

• sender-permission >= write

[fujitatomoya]

this looks reasonable for me.

@christophebedard @cottsay can you take a look?

[Ryan4253]

@clalancette @cottsay bump

[cottsay]

I don't think we can take this because of ros2/ros2_documentation#6524, right?

EDIT: Hmm, I'd guess the actual change wasn't backported. Was the documentation backport a mistake then?

[fujitatomoya]

@cottsay

the documentation backport is standard practice (release notes go to every distro branch), rclpy#1620 was never backported to Humble, and therefore dropping pytest-asyncio from the Humble image is safe?

[Ryan4253]

@cottsay I checked again and there's no use of pytest-asyncio in humble:

ryanl@ryanl:~/Desktop/rclpy$ git branch
* humble
  rolling
ryanl@ryanl:~/Desktop/rclpy$ grep -r "asyncio" .
./rclpy/test/test_executor.py:import asyncio
./rclpy/test/test_executor.py:            await asyncio.sleep(0)
./rclpy/test/test_executor.py:            await asyncio.sleep(0)
./rclpy/test/test_executor.py:            await asyncio.sleep(0)

As a comparison,

ryanl@ryan:~/Desktop/rclpy$ git branch
  humble
* rolling
ryanl@ryanl:~/Desktop/rclpy$ grep -r "pytest.mark.asyncio" .
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_timer.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_client.py:@pytest.mark.asyncio
./rclpy/test/test_async_subscription.py:@pytest.mark.asyncio
./rclpy/test/test_async_subscription.py:@pytest.mark.asyncio
./rclpy/test/test_async_subscription.py:@pytest.mark.asyncio
./rclpy/test/test_async_subscription.py:@pytest.mark.asyncio
./rclpy/test/test_async_subscription.py:@pytest.mark.asyncio
./rclpy/test/test_async_publisher.py:@pytest.mark.asyncio
./rclpy/test/test_async_publisher.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_node.py:@pytest.mark.asyncio
./rclpy/test/test_async_service.py:@pytest.mark.asyncio
./rclpy/test/test_async_service.py:@pytest.mark.asyncio
./rclpy/test/test_async_service.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio
./rclpy/test/test_async_clock.py:@pytest.mark.asyncio

I don't see any other use of pytest-asyncio in the ros2 organization otherwise from a quick github search. So as @fujitatomoya said it should be safe

[cottsay]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[ahcorde]

--packages-skip image_tools intra_process_demo

• Windows