feat(theme): make config panel and command palette overlays theme-aware#53
Open
roramirez wants to merge 1 commit into
Open
feat(theme): make config panel and command palette overlays theme-aware#53roramirez wants to merge 1 commit into
roramirez wants to merge 1 commit into
Conversation
The overlays used ~13 hardcoded RGB constants, so the config panel, command palette, and screenshot-name prompt kept fixed dark colors regardless of the active theme. Replace the constants with an `OverlayColors` set resolved from `ResolvedTheme`: the two panel backgrounds become dedicated `overlay_bg` / `overlay_bg_sel` theme fields (derived from background + color8 when a theme omits them; default.toml keeps the original values), and every other overlay color maps to an existing chrome field or palette slot. Thread `&ResolvedTheme` through draw_config_panel / draw_command_palette / draw_screenshot_name_input. Add theme tests for the explicit-override and palette-derived paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The overlays used ~13 hardcoded RGB constants, so the config panel, command palette, and screenshot-name prompt kept fixed dark colors regardless of the active theme.
Changes
OverlayColorsset resolved fromResolvedTheme.overlay_bg/overlay_bg_seltheme fields (derived frombackground+color8when a theme omits them;default.tomlkeeps the original values).&ResolvedThemethroughdraw_config_panel/draw_command_palette/draw_screenshot_name_input.Tests
Card
plan-todo/08-mant-overlays-tema.md