Fix wrong source URLs for Cardiff and Blackburn with Darwen - #2178
Fix wrong source URLs for Cardiff and Blackburn with Darwen#2178deal0f49-21 wants to merge 1 commit into
Conversation
Cardiff Council's url was set to the generic gov.uk homepage instead of cardiff.gov.uk, and Blackburn with Darwen's was set to Blaby's domain (a completely unrelated council). Found while building an attribution feature that surfaces each council's own url field to end users, which is used correctly for the actual scraper logic (both entries have skip_get_url: true so this didn't affect date-fetching), but was factually wrong for display/reference purposes. Verified the correct domains directly against each council's real website before fixing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCorrects the configured website URLs for BlackburnCouncil and CardiffCouncil in the test input data. ChangesCouncil URL corrections
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for catching this! Folded into the consolidated "July Part 2" release in #2189 (same 2-line change), so closing this one out. Credited in the PR description. Generated by Claude Code |
Summary
Both have `skip_get_url: true`, so this didn't affect actual date-fetching, but it's wrong for anything that displays/links this field as the council's source (e.g. an attribution UI, or a data-sources reference page).
How found
Building a per-scan "data sourced from X" attribution feature in a downstream app, which surfaces this url field to end users. Verified the correct domains against each council's real website before fixing.
Test plan
Summary by CodeRabbit