Skip to content

Fix Schema union memberships lookup#5663

Merged
rmosolgo merged 2 commits into
rmosolgo:masterfrom
ydah:fix-schema-union-memberships-typo
Jul 15, 2026
Merged

Fix Schema union memberships lookup#5663
rmosolgo merged 2 commits into
rmosolgo:masterfrom
ydah:fix-schema-union-memberships-typo

Conversation

@ydah

@ydah ydah commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fix a typo in Schema.union_memberships when collecting inherited union memberships without a specific type.

@ydah
ydah force-pushed the fix-schema-union-memberships-typo branch from 80c8adb to 910e078 Compare July 9, 2026 14:28
@ydah
ydah force-pushed the fix-schema-union-memberships-typo branch from 910e078 to bda4004 Compare July 9, 2026 14:36
@rmosolgo

Copy link
Copy Markdown
Owner

Hey, thanks for sharing this fix. How did you run into this problem?

I'd like to include a test in the project to make sure this code path is properly tested in the future!

@ydah

ydah commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I found this while reviewing the inheritance paths in Schema.union_memberships, rather than through a production failure. The lookup key didn't match the :union_memberships name used elsewhere.

I've added a regression test that subclasses Dummy::Schema and calls union_memberships without a type. It verifies that the inherited memberships are included.

@rmosolgo

Copy link
Copy Markdown
Owner

Got it, that makes sense. Thanks again for this fix!

@rmosolgo
rmosolgo merged commit 0e60320 into rmosolgo:master Jul 15, 2026
13 checks passed
@rmosolgo rmosolgo added this to the 2.6.6 milestone Jul 15, 2026
@ydah
ydah deleted the fix-schema-union-memberships-typo branch July 15, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants