feat(viewmodel): expose referenced view model name in PropertyData - #116
Draft
mfazekas wants to merge 1 commit into
Draft
feat(viewmodel): expose referenced view model name in PropertyData#116mfazekas wants to merge 1 commit into
mfazekas wants to merge 1 commit into
Conversation
mfazekas
force-pushed
the
mfazekas/property-data-viewmodel-name
branch
from
July 28, 2026 15:06
5b2b888 to
0dc11d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
viewModelNametoPropertyDataso callers can tell which view model aDataType::viewModelproperty references, without creating an instance just to introspect it. Symmetric withenumName.A
ViewModelPropertyViewModelonly carriesviewModelReferenceIdand aViewModelPropertyhas no link back to its owner, so the name has to be resolved through theFile:buildPropertiesDatanow takes the owningViewModelrather than its property list, and reaches the file viaViewModel::file(), which is no longerWITH_RIVE_TOOLS-only.Needed by rive-wasm to surface
viewModelNamethroughgetProperties()for TypeScript schema/codegen use cases.