fix(settings): validate language against supported locales#798
fix(settings): validate language against supported locales#798Olasunkanmi975 wants to merge 6 commits into
Conversation
|
@Olasunkanmi975 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Kindly resolve conflict and fix workflow. |
|
Great job so far There’s are just two blockers — the workflow is failing and the conflict. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
|
Hi maintainer, please review this pr |
|
The workflow is still failing |
|
@RUKAYAT-CODER please review and merge maintainer |
|
Workflow is still failing |
|
Kindly resolve conflict and fix workflow. Dont forget to pull from the main before pushing. |
##closed #779
Summary
Replaces the language length check with allowlist validation to ensure only supported locales are stored in the settings store. Unsupported locale values now automatically fall back to the default language.
Changes
SUPPORTED_LANGUAGESandDEFAULT_LANGUAGEfromsrc/locales/config.ts.patchSettingsto validate language values against the supported locale allowlist.Testing
Covered:
Validation
npm test npm run lint npm run build