Skip to content

COO-1975: fix: use case sensitive dao to check correctly uppercase user names#1153

Merged
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
jgbernalp:fix-rbac-for-uppercase-username
Jul 15, 2026
Merged

COO-1975: fix: use case sensitive dao to check correctly uppercase user names#1153
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
jgbernalp:fix-rbac-for-uppercase-username

Conversation

@jgbernalp

@jgbernalp jgbernalp commented Jul 15, 2026

Copy link
Copy Markdown
Member

This enables the case sensitive option for the Perses DAO so the SAR checks also consider user names that need case sensitivity

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp
jgbernalp requested a review from PeterYurkovich July 15, 2026 13:53
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

@jgbernalp: This pull request references COO-1975 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This enables the case sensitive option for the Perses DAO so the SAR checks also consider users names that need case sensitivity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Perses Database.File configuration now explicitly sets CaseSensitive to true, while retaining the existing folder and extension settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: peteryurkovich, simonpasquier

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title names the case-sensitive DAO fix and matches the main change.
Description check ✅ Passed The description matches the change by explaining that Perses DAO case sensitivity is enabled for SAR checks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PeterYurkovich

Copy link
Copy Markdown
Member

/lgtm

@jgbernalp

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgbernalp
jgbernalp enabled auto-merge (squash) July 15, 2026 14:24
@PeterYurkovich

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 21f54bd into rhobs:main Jul 15, 2026
12 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@jgbernalp: new pull request created: #1154

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants