Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes legacy dev-only test dependencies (Mocha/Should) and migrates the test suite to Node’s built-in test runner, reducing external tooling while keeping test coverage in-repo.
Changes:
- Replaced
mocha+shouldassertions withnode:test+node:assertin the existing test file. - Removed old devDependencies from
package.jsonand pruned them frompackage-lock.json. - Updated the npm test script to use
node --test.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/rework.js | Migrates tests from should assertions to node:assert while using node:test primitives. |
| package.json | Drops Mocha/Should dev deps and switches the test script to Node’s test runner. |
| package-lock.json | Removes lockfile entries that were only needed for the deleted devDependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.