fix(index-dtf): prevent proposal calldata from stretching the detail layout - #1085
Merged
Merged
Conversation
Co-Authored-By: Patrick <patrick.mckelvy@reserve.org>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying register-app with
|
| Latest commit: |
ced02aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bfc76a6a.register-app.pages.dev |
| Branch Preview URL: | https://devin-1786370775-fix-proposa.register-app.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On proposal detail pages whose calldata contains long unbroken hex strings (e.g. the CMC20 DTF V4 Upgrade proposal), the whole page grew wider than the viewport: the votes/status column was pushed off-screen and the page got a horizontal scrollbar.
Cause: grid items default to
min-width: auto, so the10frcontent column resolved to its min-content width — the width of the longest hex string in theJsonViewparameters block. On a 1600px viewport the[10fr_5fr]track resolved to1381.5px + 292pxinstead of920px + 460px.Fix:
grid-cols-[10fr_5fr]→grid-cols-[minmax(0,10fr)_minmax(0,5fr)]on the proposal header and body grids, plusmin-w-0on both body columns, so tracks stay at their fr ratio regardless of content.break-allon theJsonViewcontainer inraw-call-previewso long hex parameter values wrap inside the card (matching the already-wrappingExecutable codeblock) instead of overflowing it.Verified against the live proposal via a local dev server:
documentElement.scrollWidth === clientWidthat 1600px and 410px, Summary/Raw tabs and expanded executable code all contained. Governance smoke + states e2e specs pass.Link to Devin session: https://app.devin.ai/sessions/7bd70f0f9dd04123a030c0f70ed73cc9