fix(ci): don't fail open when EC release-notes dispatch fails - #3855
Open
kriscoleman wants to merge 1 commit into
Open
fix(ci): don't fail open when EC release-notes dispatch fails#3855kriscoleman wants to merge 1 commit into
kriscoleman wants to merge 1 commit into
Conversation
…registers as a failure The generate-ec-release-notes-pr step already exits 1 on a non-2xx response from the replicated-docs repository_dispatch, but continue-on-error: true masked it: GitHub reports the step conclusion as success, so a 404 still failed open (green). Removing continue-on-error lets the 404 fail the step and surface as a real failure. The step runs last (after release + release-app), so the product release is unaffected -- only the run status flags that the docs dispatch failed.
kriscoleman
enabled auto-merge (squash)
August 10, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generate-ec-release-notes-prstep already checks the HTTP status of therepository_dispatchto replicated-docs andexit 1s on a non-2xx response. Butcontinue-on-error: truemasked that failure: GitHub reports the step conclusion assuccess, so a 404 (e.g. an under-privilegedGH_PAT) still passed green — the exact fail-open this was meant to catch.Removing
continue-on-error: truelets the 404 fail the step and surface as a real, red failure. This job runs last (needs: [release, release-app, get-tag]), so the product release is already complete when it runs — a failure here only flags that the docs release-notes dispatch failed, it does not undo or block the release itself.Verified against run 31411065177: the dispatch returned 404, the step
exit 1d, but the step conclusion wassuccessbecause ofcontinue-on-error.Note: this makes the failure visible; the dispatch itself still 404s until the
GH_PATsecret holds a token with write (Contents: write) access to replicated-docs (tracked separately).