Skip to content

fix(ci): don't fail open when EC release-notes dispatch fails - #3855

Open
kriscoleman wants to merge 1 commit into
mainfrom
fix/ec-release-notes-dispatch-fail-loud
Open

fix(ci): don't fail open when EC release-notes dispatch fails#3855
kriscoleman wants to merge 1 commit into
mainfrom
fix/ec-release-notes-dispatch-fail-loud

Conversation

@kriscoleman

Copy link
Copy Markdown
Member

The generate-ec-release-notes-pr step already checks the HTTP status of the repository_dispatch to replicated-docs and exit 1s on a non-2xx response. But continue-on-error: true masked that failure: GitHub reports the step conclusion as success, so a 404 (e.g. an under-privileged GH_PAT) still passed green — the exact fail-open this was meant to catch.

Removing continue-on-error: true lets the 404 fail the step and surface as a real, red failure. This job runs last (needs: [release, release-app, get-tag]), so the product release is already complete when it runs — a failure here only flags that the docs release-notes dispatch failed, it does not undo or block the release itself.

Verified against run 31411065177: the dispatch returned 404, the step exit 1d, but the step conclusion was success because of continue-on-error.

Note: this makes the failure visible; the dispatch itself still 404s until the GH_PAT secret holds a token with write (Contents: write) access to replicated-docs (tracked separately).

…registers as a failure

The generate-ec-release-notes-pr step already exits 1 on a non-2xx response from the replicated-docs repository_dispatch, but continue-on-error: true masked it: GitHub reports the step conclusion as success, so a 404 still failed open (green). Removing continue-on-error lets the 404 fail the step and surface as a real failure. The step runs last (after release + release-app), so the product release is unaffected -- only the run status flags that the docs dispatch failed.
@kriscoleman
kriscoleman enabled auto-merge (squash) August 10, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant