Fix q_shSeFeSector infeasibility on zero solids demand - #2429
Merged
Renato-Rodrigues merged 2 commits intoAug 18, 2026
Conversation
LaviniaBaumstark
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fesosin buildings and industry for regions/periods with zero demand.v_shSeFeSector,v_shSeFe) to prevent the solver from exploring unphysically large values when demand is small.Details
The equation$v \times 0 = 0$ ).
q_shSeFeSectortriggers a local infeasibility in some REMIND scenarios (e.g., ambitious carbon budget runs where regions likeCHAhave zero industry solid demand by 2150). With zero total final energy demand, the share equation becomes singular (Because
fesosin buildings and industry is already explicitly excluded from the downstream penalty equationq_penSeFeSectorShareDev, calculating these shares is unnecessary. Excluding them fromq_shSeFeSectorprevents the zero-demand singularity without side effects on model behavior.Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)