docs(adapters): fix mapping hostname field name in usage page#288
Merged
Merged
Conversation
The Configurations list referenced client_options.mapping.hostname, which does not exist. The actual field is client_options.mapping.sensor_hostname_path, matching the SensorHostnamePath extractor (go-uspclient protocol/mapping.go) and the extractors list further down the same page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_options.mapping.hostname, which does not exist in the adapter code.client_options.mapping.sensor_hostname_path, the actual field name.Verification
MappingDescriptor.SensorHostnamePathcarries the tagsensor_hostname_pathin go-uspclient (protocol/mapping.go), and there is nohostnamekey undermapping.client_options.hostname(top-level, the adapter's own hostname) is a real field and was left untouched.🤖 Generated with Claude Code