fix: deployment to prod failing due to wrong group vars resolution - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During deployment to production, despite Ansible playbook running with env=prod, the group vars were being resolved as if it was stage deployment. This resolved in quick failure due to trying to deploy to pullsar-stage namespace, which does not exist in the prod cluster.
I have fixed ansible/inventory/hosts.yml and run the workflow manually using workflow-dispatch from this branch to ensure the changes fix this and any other potential problem with deployment to prod. The deployment to prod has run successfully, therefore I consider this to be the final fix.