Skip to content

chore(deps): [release-1.10] bump linkify-it to 5.0.1 or higher#5132

Open
alizard0 wants to merge 2 commits into
redhat-developer:release-1.10from
alizard0:RHIDP-15582
Open

chore(deps): [release-1.10] bump linkify-it to 5.0.1 or higher#5132
alizard0 wants to merge 2 commits into
redhat-developer:release-1.10from
alizard0:RHIDP-15582

Conversation

@alizard0

Copy link
Copy Markdown
Member

It bumps linkify-it to 5.0.1 or higher patching CVE-2026-48801
https://redhat.atlassian.net/browse/RHIDP-15582

@openshift-ci
openshift-ci Bot requested review from debsmita1 and jonkoops July 21, 2026 14:50
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.09%. Comparing base (da65cdf) to head (2d6d54b).
⚠️ Report is 3 commits behind head on release-1.10.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.10    #5132       +/-   ##
=================================================
+ Coverage         41.03%   69.09%   +28.05%     
=================================================
  Files               121      120        -1     
  Lines              2220     4895     +2675     
  Branches            563      535       -28     
=================================================
+ Hits                911     3382     +2471     
- Misses             1304     1508      +204     
  Partials              5        5               
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 40.36% <ø> (-0.68%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da65cdf...2d6d54b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@JessicaJHee JessicaJHee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alizard0

Copy link
Copy Markdown
Member Author

/retest

@alizard0

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@albarbaro

Copy link
Copy Markdown
Member

/lgtm

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@alizard0

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@kim-tsao kim-tsao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing the bump in the dynamic-plugins yarn.lock

@Zaperex

Zaperex commented Jul 24, 2026

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@github-actions

Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@sonarqubecloud

Copy link
Copy Markdown

@kim-tsao kim-tsao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a new commit to bump linkify-it to v5.0.2 in both the root and dynamic-plugins yarn.lock

@kim-tsao
kim-tsao dismissed their stale review July 24, 2026 20:49

added a new commit to address the request

@kim-tsao

Copy link
Copy Markdown
Member

/retest

@github-actions

Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@kim-tsao

Copy link
Copy Markdown
Member

/retest

@github-actions

Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@kim-tsao

Copy link
Copy Markdown
Member

Tests were failing because there was no rebuild after the last commit. I had to re-run hermetic build to generate a new image for the tests to pick up.

/retest

@alizard0

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

@alizard0: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm e9c0371 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants