log: move per-query api/sh_join/tweaks lines to TRACE - #166
Merged
Conversation
Electrum/Esplora/RPC benches emit one DEBUG line per call plus a sh_join timing line on any join over 10ms. That floods mainnet.log at --log-level debug. Stderr is TRACE; --api-log JSONL is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Wallet/bench query load prints one
api:line per Electrum/Esplora/RPC call at DEBUG, plussh_join:when a join takes >10ms and a tweaks timing line. That is unusable next to--log-level debug(tip perf, etc.).What
api_callstderr is TRACE.--api-logJSONL is unchanged (tail -fstill works).sh_join:andelectrum: tweaks h=…are TRACE.Pin:
api_stderr_line_is_traceplus the existing JSONL test.