net: emit per-item getdata wtx log at TRACE - #163
Merged
Conversation
One DEBUG line per peer MSG_WTX getdata drowns tip-follow logs. Counts stay on tip: perf. The bitcoind shim maps Core TestNode -loglevel=trace to --log-level trace so p2p_blocksonly still sees the debug.log needle.
rearden-grok
Bot
added
the
core-functional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One DEBUG line per peer
MSG_WTXgetdata is too noisy on tip-follow. Emit at TRACE. Counts stay ontip: perf.Core
p2p_blocksonly.pystill grepsreceived getdata for: wtxin debug.log. TestNode always passes-debugand-loglevel=trace; the bitcoind shim now takes the more verbose of those (--log-level trace) so the needle still appears.Test
cargo test -p rbitcoin-net core_log_helpers_match_step21_needlesscripts/core-functional/bitcoind.test.sh(-debug -loglevel=trace→--log-level trace)Label core-functional so
p2p_blocksonlyruns.