store: 17→18 index check before tx.head open - #160
Merged
Conversation
added 3 commits
August 19, 2026 19:36
Empty 17 indexes must rewrite meta to 18 before TxTable::open. Checking after a Class A head rebuild treats the new occupancy as leftover 17 data and refuses, leaving meta at 17.
Occupying every rbtc-scripts worker then panicking before notify_all leaves the process-wide pool blocked. Later wait_done never returns, so cargo test --workspace hangs on 2-core GHA. Drop the gate on unwind and serialize occupy tests.
The test job had no timeout (GHA default 6h), so a hung cargo test sat for hours. Bound it at 20 minutes and cancel in-progress CI on the same ref so retries and new pushes do not stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store::openran the schema-17 index refuse afterTxTable::open. Wipingtx.headon a v17metathen triggered a full MPHF rebuild; the new occupancy madeschema17_index_data_presenttrue, so open refused and never rewrotemetato 18.Move the 17→18 check (and empty-index
metabump) beforeTxTable::open.Test plan
tx.headstill refusedmetato 18metais 18