Ignore file watcher change events that omit a changes payload - #1863
Open
Hashim1999164 wants to merge 1 commit into
Open
Ignore file watcher change events that omit a changes payload#1863Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Collaborator
|
We shouldn't be dropping events. This sounds more like a version mismatch issue than a "third party watchers" issue. What's your setup? |
Author
|
The crash in #1767 came from nativewind calling FileMap.emit('change') with no ChangeEvent (react-native-css-interop onChange). I do not have a Metro version mismatch in that stack. DependencyGraph and DeltaCalculator both assume the watcher always sends addedFiles / modifiedFiles / deletedFiles. If dropping a bare change event is the wrong call, I can close this and leave it to nativewind to emit a real payload. Happy to reshape the PR if you would rather Metro treat a missing payload as an empty change set instead of returning early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1767
Some third party watchers emit a bare change event with no ChangeEvent payload. DeltaCalculator and DependencyGraph then read changes.addedFiles and throw.
These handlers now return early when the payload is missing, so a bad event does not crash the bundler.
DeltaCalculator tests cover a change emit with no argument and with an empty object.
Changelog: [Fix] Ignore file watcher change events that omit a changes payload