RDKEMW-20349 : Change discovery.watchedV2 return type to void#80
Open
swethasukumarr wants to merge 2 commits into
Open
RDKEMW-20349 : Change discovery.watchedV2 return type to void#80swethasukumarr wants to merge 2 commits into
swethasukumarr wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Discovery watchedV2 API to be fire-and-forget (no return payload), aligning the C++ interface/implementation, tests, demo output, and OpenRPC fixtures with a void/null result.
Changes:
- Change
Discovery.watchedV2return type fromResult<bool>toResult<void>and switch implementation fromhelper_.get(...)tohelper_.invoke(...). - Update unit/component tests and the API demo app to stop expecting a boolean result.
- Update OpenRPC fixtures to define a
nullresult schema andnullexample values forwatchedV2.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
include/firebolt/discovery.h |
Updates the public interface return type and return docs for watchedV2. |
src/discovery_impl.h |
Updates DiscoveryImpl method signature to Result<void>. |
src/discovery_impl.cpp |
Implements watchedV2 as an invoke returning Result<void>. |
test/unit/discoveryTest.cpp |
Adjusts mocks and assertions for Result<void> and invoke(...). |
test/component/discoveryTest.cpp |
Removes boolean result expectation for watchedV2. |
test/api_test_app/apis/discoveryDemo.cpp |
Updates demo output to reflect no boolean return value. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Changes watchedV2 result schema/examples to null. |
docs/openrpc/openrpc/discovery.json |
Changes watchedV2 result schema/examples to null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.