Release 0.6.2#79
Merged
Merged
Conversation
RDKEMW-17483: Change Discovery.watched method return type void to bool
brendanobra
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This release PR restores the Discovery.watched API to its pre-v0.6.0 behavior by changing it back to returning Result<bool> (instead of Result<void>), and aligns implementation, tests, and OpenRPC documentation accordingly.
Changes:
- Updated the public
IDiscovery::watchedAPI andDiscoveryImpl::watchedimplementation to returnResult<bool>and fetch a boolean result from the helper. - Updated unit/component tests and the demo app output to validate/print the boolean return value.
- Updated OpenRPC specs and the changelog to reflect the boolean result for
Discovery.watched.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
include/firebolt/discovery.h |
Changes watched return type to Result<bool> and updates API docstring. |
src/discovery_impl.h |
Updates DiscoveryImpl::watched signature to Result<bool>. |
src/discovery_impl.cpp |
Switches Discovery.watched from invoke (void) to get<..., bool> to retrieve a boolean result. |
test/unit/discoveryTest.cpp |
Updates mocks and assertions to validate the boolean return value and payload handling. |
test/component/discoveryTest.cpp |
Adds assertion that returned value matches OpenRPC example boolean. |
test/api_test_app/apis/discoveryDemo.cpp |
Prints the boolean result of Discovery.watched. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Updates Discovery.watched result schema and examples from null to boolean. |
docs/openrpc/openrpc/discovery.json |
Updates module OpenRPC doc for watched to return boolean with updated examples. |
CHANGELOG.md |
Adds 0.6.2 entry documenting the Discovery.watched return type revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.