Skip to content

Release 0.6.2#79

Merged
swethasukumarr merged 5 commits into
mainfrom
develop
Jun 12, 2026
Merged

Release 0.6.2#79
swethasukumarr merged 5 commits into
mainfrom
develop

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This release PR restores the Discovery.watched API to its pre-v0.6.0 behavior by changing it back to returning Result<bool> (instead of Result<void>), and aligns implementation, tests, and OpenRPC documentation accordingly.

Changes:

  • Updated the public IDiscovery::watched API and DiscoveryImpl::watched implementation to return Result<bool> and fetch a boolean result from the helper.
  • Updated unit/component tests and the demo app output to validate/print the boolean return value.
  • Updated OpenRPC specs and the changelog to reflect the boolean result for Discovery.watched.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
include/firebolt/discovery.h Changes watched return type to Result<bool> and updates API docstring.
src/discovery_impl.h Updates DiscoveryImpl::watched signature to Result<bool>.
src/discovery_impl.cpp Switches Discovery.watched from invoke (void) to get<..., bool> to retrieve a boolean result.
test/unit/discoveryTest.cpp Updates mocks and assertions to validate the boolean return value and payload handling.
test/component/discoveryTest.cpp Adds assertion that returned value matches OpenRPC example boolean.
test/api_test_app/apis/discoveryDemo.cpp Prints the boolean result of Discovery.watched.
docs/openrpc/the-spec/firebolt-open-rpc.json Updates Discovery.watched result schema and examples from null to boolean.
docs/openrpc/openrpc/discovery.json Updates module OpenRPC doc for watched to return boolean with updated examples.
CHANGELOG.md Adds 0.6.2 entry documenting the Discovery.watched return type revert.

@swethasukumarr swethasukumarr merged commit ada3bf8 into main Jun 12, 2026
20 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants