RDKEMW-17483: Change Discovery.watched method return type void to bool

[swethasukumarr]

No description provided.

[Copilot]

Pull request overview

This PR updates the Firebolt C++ client’s Discovery module contract so Discovery.watched returns a boolean result (instead of void), and aligns implementation, tests, demo output, and OpenRPC fixtures to the new return shape.

Changes:

• Change IDiscovery::watched / DiscoveryImpl::watched return type from Result<void> to Result<bool> and fetch a boolean result via helper_.get(...).
• Update unit/component tests to assert the returned boolean and adjust mocking from invoke to getJson.
• Update OpenRPC fixtures (firebolt-open-rpc.json and Discovery module OpenRPC) so Discovery.watched returns a boolean result with updated examples.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
include/firebolt/discovery.h	Updates the public watched() API signature to Result<bool> and adjusts its doc comment.
src/discovery_impl.h	Updates the DiscoveryImpl::watched() override signature to match the interface.
src/discovery_impl.cpp	Implements watched() to call helper_.get<..., bool>(...) and return a boolean result.
test/unit/discoveryTest.cpp	Updates unit tests/mocking to validate boolean return and JSON payload expectations.
test/component/discoveryTest.cpp	Updates component test to compare returned boolean against the OpenRPC fixture value.
test/api_test_app/apis/discoveryDemo.cpp	Updates demo output to print the boolean result for Discovery.watched.
docs/openrpc/the-spec/firebolt-open-rpc.json	Updates the spec fixture for Discovery.watched to return boolean (and updates examples).
docs/openrpc/openrpc/discovery.json	Updates module-level OpenRPC for watched to return boolean (and updates examples).

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.