RDKEMW-19785 : control manager - remove deprecated RFCs#243
Open
dwolaver wants to merge 8 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes deprecated TR-181/RFC (XCONF) configuration hooks from the Control Manager plugin, simplifying runtime configuration to rely on JSON/DB settings and eliminating legacy override paths.
Changes:
- Removed voice-side XCONF/TR-181 processing (
process_xconf) including base64 VSDK config and assorted RF4CE/voice RFC overrides. - Removed RF4CE legacy TR-181 override paths for polling configuration, response time, ASB, and DSP XCONF configuration.
- Fixed a TR-181 constant name typo for Power Manager revision detection (
CTRLM_RT181_*→CTRLM_TR181_*) and removed Thread Monitor minidump TR-181 override.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/voice/ctrlm_voice_obj.h | Removes process_xconf virtual API from the voice object. |
| src/voice/ctrlm_voice_obj.cpp | Removes invocation/implementation of voice XCONF/TR-181 processing during voice configuration. |
| src/rf4ce/network/attributes/ctrlm_rf4ce_network_attr_config.h | Removes legacy RFC method declaration from RF4CE response time attribute. |
| src/rf4ce/network/attributes/ctrlm_rf4ce_network_attr_config.cpp | Removes legacy TR-181 reads for RF4CE response time overrides. |
| src/rf4ce/ctrlm_rf4ce_network.h | Removes declarations for RF4CE TR-181/XCONF processing helpers. |
| src/rf4ce/ctrlm_rf4ce_network.cpp | Removes RF4CE TR-181/XCONF overrides (polling, audio profile target, voice encryption, host decryption, ASB, DSP config). |
| src/ipc/ctrlm_ipc_iarm_powermanager.cpp | Updates to the corrected TR-181 constant name for Power Manager revision detection. |
| src/ctrlm_tr181.h | Removes deprecated RF4CE/voice TR-181 macro definitions; renames Power RFC macro to CTRLM_TR181_POWER_RFC_PWRMGR2. |
| src/ctrlm_main.cpp | Removes Thread Monitor minidump enablement TR-181 override read at init. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.