backend: Add output image offset parameters#71
Merged
Conversation
davidplowman
had a problem deploying
to
camera-test
GitHub Actions
Failure
Collaborator
Author
|
@naushir Seems to have failed some gstreamer tests? I'm struggling a bit to think that this change is the cause, what do you think? |
Collaborator
|
I suspect the gstreamer was the first failure, but we may have others as well. The CI quits after the first failure so we don't see the others. I'm triggering a manual test run so we can check if this is the case. |
The output images can now be offset into a "window" within a larger image buffer. We need only supply two extra x, y offsets to the output format configurations, and apply them when calculating buffer addresses. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Collaborator
|
Tests should now be passing. Turns out it was due to the PR branch being behind main, so all we needed to do was rebase the output-offsets tree. |
naushir
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output images can now be offset into a "window" within a larger image buffer.
We need only supply two extra x, y offsets to the output format configurations, and apply them when calculating buffer addresses.