Bundle rename alignment: dotted names, generic/ tier, proxmox decom#113
Open
pparage wants to merge 5 commits into
Open
Bundle rename alignment: dotted names, generic/ tier, proxmox decom#113pparage wants to merge 5 commits into
pparage wants to merge 5 commits into
Conversation
… playbook validation Centralize the four duplicated name-validation regexes into a single _PLAYBOOK_NAME_REGEX and widen the character class to permit dots inside a segment, so the new bundle naming grammar (range42-playbooks#133), e.g. generic/software.install.docker, passes format validation. A '.'/'..' segment is rejected explicitly; real traversal stays closed by the existing is_relative_to guard in _resolve_file. Non-breaking: existing hyphen/slash names still match.
…tier bundles Align the resolver bundle paths with the range42-playbooks#133 rename: core/linux/ubuntu/install/docker -> generic/software.install.docker core/linux/ubuntu/install/docker-compose -> generic/software.install.docker_compose core/linux/ubuntu/install/basic-packages -> generic/software.install.basic_packages core/linux/ubuntu/install/dot-files -> generic/software.install.dotfiles core/linux/ubuntu/configure/add-user -> generic/credentials.create.user Also fixes a copy-paste bug where the docker-compose route resolved to the docker bundle. HTTP route paths are left unchanged (API surface). Gated: these resolve at runtime only once range42-playbooks#133 is deployed to the playbooks dir.
Delete the 24 create/start/stop/pause/resume/delete/snapshot routes for the fixed admin/vuln/student VM sets, plus their Pattern C helpers and _check_* validators. The underlying bundles are retired to decom/ in range42-playbooks#133 and had no live caller (the deployer-UI composables that imported them were never wired to a trigger; the v1 deployments pipeline supersedes the fixed-topology model). Prunes the 24 entries from the routes golden manifest and drops the now-empty validator test module.
The /v0/admin/proxmox/vms/vm_ids/{stop,stop_force,start,pause,resume,delete}
routes drove mass start/stop/delete through the decom'd
start-stop-pause-resume-vms-vuln / delete-vms-vuln bundles (range42-playbooks#133).
They have no UI caller and v1 already exposes per-VM lifecycle directly
(POST /v1/proxmox/hosts/{host}/vms/{vmid}/status/{action}, DELETE .../vms/{vmid}),
so no live backend code depends on decom/ anymore.
Removes the vm_ids_router (helper + 6 routes), unwires it in routes/__init__,
drops the now-unused mass schema imports, and prunes the 6 routes from the
golden manifest. Confirmed with Ben.
Tests green (pre-existing test_expand_replication failure unrelated).
The 24 proxmox DefaultVms bundle routes were removed in e4dd555/e335626; their request/reply schemas and BundlesCoreProxmoxConfigureDefaultVms backward-compat aliases had no remaining callers. Drop them plus the two test references. Ubuntu (generic/) bundle schemas retained.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns backend-api with Ben's bundle naming grammar rename (range42-playbooks #133 dotted
<tier>/<subject>.<verb>.<object>, dropscore/; #136 per-bundlebundle_parameters.json).Commits
c881612allow dotted bundle names in playbook validation (unified regex, permits.) — non-breaking, mergeable standalone001fc54repoint ubuntu install/configure routes atgeneric/tier bundles (+ fix docker-compose→docker copy-paste bug)e4dd555remove 24 retired proxmox default-VM bundle routes + Pattern C helpers/validators (golden 80→56)e335626remove v0 mass VM lifecycle routes reusing decom'd bundles (golden 56→50; v1 does per-VM lifecycle directly)511feaeremove dead proxmox default-VM bundle schemas + backward-compat aliases + their testsTests
393 passed, 1 failed (
test_expand_replication_vectors— pre-existing on this branch, unrelated).Do not merge until range42-playbooks #133 is deployed to the playbooks dir. Commit
001fc54resolves ubuntu bundle endpoints togeneric/*paths that do not exist until #133 lands — merging early makes those endpoints 500. As of 2026-07-16, #133 is not yet on the playbooks remote andbundles/decom/does not exist.No UI caller for the ubuntu bundles today, so blast radius is direct API calls only — but still a latent break until #133.