Skip to content

ci: plumb RPC_URL_ETHEREUM_FORK through the sol workflows#259

Open
hardyjosh wants to merge 1 commit into
mainfrom
feat/ethereum-fork-rpc
Open

ci: plumb RPC_URL_ETHEREUM_FORK through the sol workflows#259
hardyjosh wants to merge 1 commit into
mainfrom
feat/ethereum-fork-rpc

Conversation

@hardyjosh

@hardyjosh hardyjosh commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Adds Ethereum mainnet to the fork-RPC set across rainix-sol.yaml, rainix-sol-test.yaml and rainix-manual-sol-artifacts.yaml: optional secret declaration, composite passthrough, and the ETHEREUM_RPC_URL env mapping with the same vars.* fallback as every other network.

Motivation: ST0x is adding Ethereum mainnet as a deploy + fork-test network in S01-Issuer/st0x.deploy. Its foundry.toml maps the ethereum rpc alias to ETHEREUM_RPC_URL, which these workflows previously never set. Consumers that don't set the new secret/var are unaffected (optional, falls back exactly like the existing networks).

🤖 Generated with Claude Code

https://claude.ai/code/session_01VPs1hCTxusmaSeFKvoc4Kr

Summary by CodeRabbit

  • New Features
    • Added optional Ethereum fork RPC secret support to workflow-triggered Solidity jobs.
    • Passed the Ethereum RPC URL through to deployment and test steps when available, with a safe fallback if unset.

Adds Ethereum mainnet to the fork-RPC set: secret declaration in
rainix-sol.yaml / rainix-sol-test.yaml / rainix-manual-sol-artifacts.yaml,
passthrough in the composite caller, and the ETHEREUM_RPC_URL env mapping
(with the same vars.* fallback as the other networks).

Motivation: ST0x is adding Ethereum mainnet as a deploy + fork-test
network in S01-Issuer/st0x.deploy; its foundry.toml maps the ethereum rpc
alias to ETHEREUM_RPC_URL, which these workflows previously never set.
Optional like the other fork secrets — consumers that don't set it are
unaffected.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VPs1hCTxusmaSeFKvoc4Kr
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 99328408-335e-42d9-a850-42a678ba3300

📥 Commits

Reviewing files that changed from the base of the PR and between 0d86e55 and 07c9348.

📒 Files selected for processing (3)
  • .github/workflows/rainix-manual-sol-artifacts.yaml
  • .github/workflows/rainix-sol-test.yaml
  • .github/workflows/rainix-sol.yaml

📝 Walkthrough

Walkthrough

Three GitHub Actions workflow files are updated to accept a new optional RPC_URL_ETHEREUM_FORK secret via workflow_call, which is then wired into deploy step or job environment variables (with variable/empty-string fallbacks), or forwarded into a nested workflow's secrets mapping.

Changes

RPC_URL_ETHEREUM_FORK Secret Wiring

Layer / File(s) Summary
Manual sol artifacts deploy workflow
.github/workflows/rainix-manual-sol-artifacts.yaml
Adds optional RPC_URL_ETHEREUM_FORK secret to workflow_call and sets ETHEREUM_RPC_URL env for the deploy step using secret, then variable, then empty-string fallback.
Sol test workflow env wiring
.github/workflows/rainix-sol-test.yaml
Adds optional RPC_URL_ETHEREUM_FORK secret to workflow_call and sets ETHEREUM_RPC_URL in job env with fallback to the repo variable.
Sol workflow secrets forwarding
.github/workflows/rainix-sol.yaml
Adds optional RPC_URL_ETHEREUM_FORK secret to workflow_call and forwards it into the test job's secrets mapping.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • rainlanguage/rainix#237: Both PRs update .github/workflows/rainix-manual-sol-artifacts.yaml to declare and wire RPC_URL_ETHEREUM_FORK as an optional workflow_call secret into the deploy step's ETHEREUM_RPC_URL environment.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: threading RPC_URL_ETHEREUM_FORK through the sol workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ethereum-fork-rpc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant