fix(admin)!: make kid required for create_jwt#42
Merged
Conversation
The kid (key identifier) is required when creating a JWT on an endpoint via POST /endpoints/:id/security/jwts. Reflect that in the typed surface so callers get a compile/type error instead of a server-side rejection. - core: CreateJwtRequest.kid is now String (was Option<String>) - python: create_jwt(id, kid, public_key=None, name=None) - node: CreateJwtRequest.kid is now required - ruby: kid validated via hash_require_string; rbs updated
ErikTech
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
kida required parameter forPOST /endpoints/:id/security/jwts(create_jwt). Previously it was optional in the SDK's typed surface, so callers omitting it only found out via a server-side rejection. Now they get a compile/type error.Changes across all four bindings:
CreateJwtRequest.kidis nowString(wasOption<String>)create_jwt(id, kid, public_key=None, name=None)CreateJwtRequest.kidis now required (kid: string)hash_require_string;.rbsupdated tokid: Stringkidas requiredBreaking change
This tightens the type for callers not already passing
kid. Warrants a minor bump and a!-marked changeset.Verification
cargo check,just lint,just node-build,just python-build,just ruby-build,just testall pass (211 tests, 0 failures).