-
Notifications
You must be signed in to change notification settings - Fork 38
Add Audio_Hamoa: ALSA-based audio playback and recording tests for Ha… #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Teja Swaroop (tmoida)
wants to merge
1
commit into
qualcomm-linux:main
Choose a base branch
from
tmoida:feature/audio-hamoa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
Runner/suites/Multimedia/Audio/AudioPlayback/AudioPlayback_Hamoa_Handset.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| metadata: | ||
| name: audio-playback-hamoa-handset | ||
| format: "Lava-Test Test Definition 1.0" | ||
| description: "Audio Hamoa handset playback validation (4-way speaker system)" | ||
| os: | ||
| - linux | ||
| scope: | ||
| - functional | ||
|
|
||
| params: | ||
| AUDIO_BACKEND: "alsa" # Audio backend: alsa, default: alsa | ||
| ALSA_PROFILE: "hamoa" # ALSA profile: hamoa, default: hamoa | ||
| DEVICE: "handset" # Device to test: handset or headset, default: handset | ||
| CLIP_NAMES: "playback_config1" # Clip configuration name for auto-discovery, default: playback_config1 | ||
| AUDIO_CLIPS_BASE_DIR: "/home/AudioClips" # Path to audio clips directory, default: /home/AudioClips | ||
| LOOPS: 1 # Number of playback loops, default: 1 | ||
| TIMEOUT: "10s" # Playback timeout per loop (e.g., 15s, 0=none), default: 10s | ||
| DMESG_SCAN: 1 # Scan dmesg for errors after playback, default: 1 | ||
| VERBOSE: 0 # Enable verbose logging, default: 0 | ||
| RES_SUFFIX: "Hamoa_Handset" # Suffix for unique result file, default: Hamoa_Handset | ||
| LAVA_TESTCASE_ID: "AudioPlayback_Hamoa_Handset" # Unique testcase ID for LAVA, default: AudioPlayback_Hamoa_Handset | ||
|
|
||
| run: | ||
| steps: | ||
| - REPO_PATH=$PWD | ||
| - cd Runner/suites/Multimedia/Audio/AudioPlayback/ | ||
| - ./run.sh --backend "${AUDIO_BACKEND}" --alsa-profile "${ALSA_PROFILE}" --device "${DEVICE}" --clip-name "${CLIP_NAMES}" --audio-clips-path "${AUDIO_CLIPS_BASE_DIR}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --res-suffix "${RES_SUFFIX}" --lava-testcase-id "${LAVA_TESTCASE_ID}" || true | ||
| - $REPO_PATH/Runner/utils/send-to-lava.sh AudioPlayback${RES_SUFFIX:+_${RES_SUFFIX}}.res |
28 changes: 28 additions & 0 deletions
28
Runner/suites/Multimedia/Audio/AudioPlayback/AudioPlayback_Hamoa_Headset.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| metadata: | ||
| name: audio-playback-hamoa-headset | ||
| format: "Lava-Test Test Definition 1.0" | ||
| description: "Audio Hamoa headset playback validation (stereo headphones)" | ||
| os: | ||
| - linux | ||
| scope: | ||
| - functional | ||
|
|
||
| params: | ||
| AUDIO_BACKEND: "alsa" # Audio backend: alsa, default: alsa | ||
| ALSA_PROFILE: "hamoa" # ALSA profile: hamoa, default: hamoa | ||
| DEVICE: "headset" # Device to test: handset or headset, default: headset | ||
| CLIP_NAMES: "playback_config1" # Clip configuration name for auto-discovery, default: playback_config1 | ||
| AUDIO_CLIPS_BASE_DIR: "/home/AudioClips" # Path to audio clips directory, default: /home/AudioClips | ||
| LOOPS: 1 # Number of playback loops, default: 1 | ||
| TIMEOUT: "10s" # Playback timeout per loop (e.g., 15s, 0=none), default: 10s | ||
| DMESG_SCAN: 1 # Scan dmesg for errors after playback, default: 1 | ||
| VERBOSE: 0 # Enable verbose logging, default: 0 | ||
| RES_SUFFIX: "Hamoa_Headset" # Suffix for unique result file, default: Hamoa_Headset | ||
| LAVA_TESTCASE_ID: "AudioPlayback_Hamoa_Headset" # Unique testcase ID for LAVA, default: AudioPlayback_Hamoa_Headset | ||
|
|
||
| run: | ||
| steps: | ||
| - REPO_PATH=$PWD | ||
| - cd Runner/suites/Multimedia/Audio/AudioPlayback/ | ||
| - ./run.sh --backend "${AUDIO_BACKEND}" --alsa-profile "${ALSA_PROFILE}" --device "${DEVICE}" --clip-name "${CLIP_NAMES}" --audio-clips-path "${AUDIO_CLIPS_BASE_DIR}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --res-suffix "${RES_SUFFIX}" --lava-testcase-id "${LAVA_TESTCASE_ID}" || true | ||
| - $REPO_PATH/Runner/utils/send-to-lava.sh AudioPlayback${RES_SUFFIX:+_${RES_SUFFIX}}.res |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
Runner/suites/Multimedia/Audio/AudioRecord/AudioRecord_Hamoa_Handset.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| metadata: | ||
| name: audio-record-hamoa-handset | ||
| format: "Lava-Test Test Definition 1.0" | ||
| description: "Audio Hamoa handset capture validation (built-in microphone)" | ||
| os: | ||
| - linux | ||
| scope: | ||
| - functional | ||
|
|
||
| params: | ||
| AUDIO_BACKEND: "alsa" # Audio backend: alsa, default: alsa | ||
| ALSA_PROFILE: "hamoa" # ALSA profile: hamoa, default: hamoa | ||
| DEVICE: "handset" # Device to test: handset or headset, default: handset | ||
| CONFIG_NAMES: "record_config1" # Test specific configs (e.g., "record_config1 record_config2"), default: record_config1 | ||
| RECORD_SECONDS: "5s" # Recording duration with unit suffix (e.g., "5s", "10s", "30s"), default: 5s | ||
| LOOPS: 1 # Number of recording loops, default: 1 | ||
| DMESG_SCAN: 1 # Scan dmesg for errors after recording, default: 1 | ||
| VERBOSE: 0 # Enable verbose logging, default: 0 | ||
| RES_SUFFIX: "Hamoa_Handset" # Suffix for unique result file, default: Hamoa_Handset | ||
| LAVA_TESTCASE_ID: "AudioRecord_Hamoa_Handset" # Unique testcase ID for LAVA, default: AudioRecord_Hamoa_Handset | ||
|
|
||
| run: | ||
| steps: | ||
| - REPO_PATH=$PWD | ||
| - cd Runner/suites/Multimedia/Audio/AudioRecord/ | ||
| - ./run.sh --backend "${AUDIO_BACKEND}" --alsa-profile "${ALSA_PROFILE}" --device "${DEVICE}" --config-name "${CONFIG_NAMES}" --record-seconds "${RECORD_SECONDS}" --loops "${LOOPS}" --res-suffix "${RES_SUFFIX}" --lava-testcase-id "${LAVA_TESTCASE_ID}" || true | ||
| - $REPO_PATH/Runner/utils/send-to-lava.sh AudioRecord${RES_SUFFIX:+_${RES_SUFFIX}}.res |
27 changes: 27 additions & 0 deletions
27
Runner/suites/Multimedia/Audio/AudioRecord/AudioRecord_Hamoa_Headset.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| metadata: | ||
| name: audio-record-hamoa-headset | ||
| format: "Lava-Test Test Definition 1.0" | ||
| description: "Audio Hamoa headset capture validation (headset microphone)" | ||
| os: | ||
| - linux | ||
| scope: | ||
| - functional | ||
|
|
||
| params: | ||
| AUDIO_BACKEND: "alsa" # Audio backend: alsa, default: alsa | ||
| ALSA_PROFILE: "hamoa" # ALSA profile: hamoa, default: hamoa | ||
| DEVICE: "headset" # Device to test: handset or headset, default: headset | ||
| CONFIG_NAMES: "record_config1" # Test specific configs (e.g., "record_config1 record_config2"), default: record_config1 | ||
| RECORD_SECONDS: "5s" # Recording duration with unit suffix (e.g., "5s", "10s", "30s"), default: 5s | ||
| LOOPS: 1 # Number of recording loops, default: 1 | ||
| DMESG_SCAN: 1 # Scan dmesg for errors after recording, default: 1 | ||
| VERBOSE: 0 # Enable verbose logging, default: 0 | ||
| RES_SUFFIX: "Hamoa_Headset" # Suffix for unique result file, default: Hamoa_Headset | ||
| LAVA_TESTCASE_ID: "AudioRecord_Hamoa_Headset" # Unique testcase ID for LAVA, default: AudioRecord_Hamoa_Headset | ||
|
|
||
| run: | ||
| steps: | ||
| - REPO_PATH=$PWD | ||
| - cd Runner/suites/Multimedia/Audio/AudioRecord/ | ||
| - ./run.sh --backend "${AUDIO_BACKEND}" --alsa-profile "${ALSA_PROFILE}" --device "${DEVICE}" --config-name "${CONFIG_NAMES}" --record-seconds "${RECORD_SECONDS}" --loops "${LOOPS}" --res-suffix "${RES_SUFFIX}" --lava-testcase-id "${LAVA_TESTCASE_ID}" || true | ||
| - $REPO_PATH/Runner/utils/send-to-lava.sh AudioRecord${RES_SUFFIX:+_${RES_SUFFIX}}.res |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audio_common.sh already sources alsa_common.sh, but this runner also sources alsa_common.sh directly. Helper loading is duplicated and can become unsafe if alsa_common.sh later adds non-idempotent initialization.
Recommended fix: pick one convention: either let audio_common.sh source ALSA helpers, or require callers to source both explicitly, but do not do both.