QCLINUX: qcom.config: Enable VCAN support

[q-AnupKulkarni]

Enable Virtual CAN support to enable RTSS CAN module to communicate with user-space
applications using SocketCAN APIs.

CRs-Fixed: 4592789

[qlijarvis]

PR #1444 — validate-patch

PR: #1444

Verdict	Issues	Detailed Report
⚠️	1	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Technical validation:

• ✅ All three config options (CONFIG_CAN, CONFIG_CAN_DEV, CONFIG_CAN_VCAN) are valid kernel configs
• ✅ Proper comment header added ("# Virtual CAN support")
• ✅ Logical placement after GPU Virtualization section
• ✅ Appropriate config values (y for core, m for module)
• ⚠️ Spelling error in commit message needs correction

Recommendation: Request author to fix "commmunicate" → "communicate" in the commit message body, then approve.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1444 - QCLINUX: qcom.config: Enable VCAN support
Upstream commit: N/A (vendor-only config change)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit (QCLINUX: prefix)
Body preserves rationale	✅	Clear rationale for enabling VCAN support
Fixes tag present/correct	N/A	Not a fix; new feature enablement
Authorship preserved	✅	Author and SOB match
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/configs/qcom.config	✅	Valid CAN config options added with proper comment

Issues

• Typo in commit message body: "commmunicate" should be "communicate" (line 3 of body text has three 'm's instead of two)

Verdict

Merge after fixing the typo in the commit message. The technical change is correct and appropriate.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Technical validation:

• ✅ All three config options (CONFIG_CAN, CONFIG_CAN_DEV, CONFIG_CAN_VCAN) are valid kernel configs
• ✅ Proper comment header added ("# Virtual CAN support")
• ✅ Logical placement after GPU Virtualization section
• ✅ Appropriate config values (y for core, m for module)
• ⚠️ Spelling error in commit message needs correction

Recommendation: Request author to fix "commmunicate" → "communicate" in the commit message body, then approve.

[qlijarvis]

PR #1444 — checker-log-analyzer

PR: #1444
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28496079869

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues (0 errors, 0 warnings, 0 checks)
dt-binding-check	⏭️	Skipped - no changes in Documentation/devicetree/bindings
dtb-check	⏭️	Skipped - no changes in Devicetree
sparse-check	⏭️	Skipped - no C file changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	FAILED - commit subject missing required prefix
tag-check	N/A	Not applicable for this PR type
qcom-next-check	N/A	Not applicable (QCLINUX: prefix used)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1444 - QCLINUX: qcom.config: Enable VCAN support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28496079869

Checker	Result	Summary
checkpatch	✅	No style issues (0 errors, 0 warnings, 0 checks)
dt-binding-check	⏭️	Skipped - no changes in Documentation/devicetree/bindings
dtb-check	⏭️	Skipped - no changes in Devicetree
sparse-check	⏭️	Skipped - no C file changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	FAILED - commit subject missing required prefix
tag-check	N/A	Not applicable for this PR type
qcom-next-check	N/A	Not applicable (QCLINUX: prefix used)

---

❌ check-patch-compliance

Root cause: Commit subject "QCLINUX: qcom.config: Enable VCAN support" does not start with a required prefix for kernel-topics PRs.

Failure details:

2026-07-01T05:53:58.7403684Z Checking commit: QCLINUX: qcom.config: Enable VCAN support
2026-07-01T05:53:58.7418621Z Commit summary does not start with a required prefix
2026-07-01T05:53:58.7419239Z Leaving /opt/actions-runner/_work/kernel-config/kernel-config/kernel
2026-07-01T05:53:58.7434939Z ##[error]Process completed with exit code 1.

The check-patch-compliance checker enforces that commits in kernel-topics must use one of the following subject prefixes:

• UPSTREAM: - for patches already merged in mainline Linux
• FROMLIST: - for patches posted to upstream mailing lists but not yet merged
• BACKPORT: - for backported patches with modifications
• FROMGIT: - for patches cherry-picked from another git tree

The current subject uses QCLINUX: which is not a recognized prefix for kernel-topics. This prefix is typically used for internal Qualcomm-specific changes that are not intended for upstream submission.

Fix:

Since this patch enables Virtual CAN support (a standard Linux kernel feature) in the Qualcomm kernel config, you should determine the appropriate prefix based on the patch's origin:

1. If this is a new config-only change (not from upstream), use:

   QCLINUX: arm64: configs: qcom.config: Enable VCAN support
   

   However, note that QCLINUX: may not be accepted in kernel-topics. Check with your maintainer if config-only changes require a different workflow or repository.

2. If this follows an upstream pattern, consider using:

   FROMLIST: arm64: configs: qcom.config: Enable VCAN support
   

   And include a Link: tag pointing to the relevant upstream discussion or similar config change.

3. Most likely fix - Since this is a Qualcomm-specific kernel config change, this PR may belong in a different repository (like kernel-config directly) rather than kernel-topics, OR the checker rules need to be updated to allow QCLINUX: prefix for config-only changes.

Reproduce locally:

cd /path/to/kernel-topics
git log -1 --format="%s" ee795b1327a6
# Check if subject starts with UPSTREAM:/FROMLIST:/BACKPORT:/FROMGIT:

---

Verdict

1 blocker to fix: The commit subject must use an approved prefix (UPSTREAM:/FROMLIST:/BACKPORT:/FROMGIT:) or this change should be submitted through a different workflow if it's a Qualcomm-internal config change. Consult with the kernel-topics maintainer on the correct approach for kernel config additions.

All other checkers passed or were correctly skipped (no relevant code changes for DT, sparse, or UAPI checks).

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/config'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/config

[qlijarvis]

PR #1444 — validate-patch

PR: #1444

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: No — commit 028d9b6 not found in current qcom-next (HEAD: 9f3cbcb); CAN config options (CONFIG_CAN, CONFIG_CAN_DEV, CONFIG_CAN_VCAN) not present in qcom.config

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1444 - QCLINUX: arm64: qcom.config: Enable VCAN support
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit; no upstream equivalent
Body preserves rationale	✅	Clear explanation: enables RTSS CAN module to communicate with user-space via SocketCAN APIs
Fixes tag present/correct	N/A	Not a fix; new feature enablement
Authorship preserved	✅	Author: q-AnupKulkarni anupkulk@qti.qualcomm.com
Backport note (if applicable)	N/A	Not a backport; vendor-specific config change

Diff

File	Status	Notes
arch/arm64/configs/qcom.config	✅	Clean addition of 3 CAN config options after GPU virtualization section; proper formatting with comment header

Verdict

Merge as-is — clean vendor config change with clear rationale and correct placement.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: No — commit 028d9b6 not found in current qcom-next (HEAD: 9f3cbcb); CAN config options (CONFIG_CAN, CONFIG_CAN_DEV, CONFIG_CAN_VCAN) not present in qcom.config

[qlijarvis]

PR #1444 — checker-log-analyzer

PR: #1444
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28499576015

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	⏭️	Skipped - no code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	FAILED - Invalid commit subject prefix
tag-check	N/A	Not applicable for config-only changes
qcom-next-check	⚠️	Requires FROMLIST:/UPSTREAM:/BACKPORT: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1444 - QCLINUX: arm64: qcom.config: Enable VCAN support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28499576015

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	⏭️	Skipped - no code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	FAILED - Invalid commit subject prefix
tag-check	N/A	Not applicable for config-only changes
qcom-next-check	⚠️	Requires FROMLIST:/UPSTREAM:/BACKPORT: prefix

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix which is not a recognized upstream compliance prefix.

Failure details:

2026-07-01T07:15:37.7577500Z Checking commit: QCLINUX: arm64: qcom.config: Enable VCAN support
2026-07-01T07:15:37.7594697Z Commit summary does not start with a required prefix
2026-07-01T07:15:37.7612601Z ##[error]Process completed with exit code 1.

Fix: Update the commit subject to use one of the required prefixes:

1. If this is a downstream-only change (recommended for config changes):

   • Use no special prefix, just: arm64: qcom.config: Enable VCAN support
   • Or if the checker requires a prefix for all commits, consider: DOWNSTREAM: arm64: qcom.config: Enable VCAN support

2. If based on an upstream patch:

   • Use UPSTREAM: arm64: qcom.config: Enable VCAN support if already merged upstream
   • Use FROMLIST: arm64: qcom.config: Enable VCAN support if from a mailing list but not yet merged
   • Use BACKPORT: arm64: qcom.config: Enable VCAN support if backporting from a newer kernel version

3. Most likely correct approach for a Qualcomm-specific config change:

   arm64: qcom.config: Enable VCAN support
   
   Enable Virtual CAN support to enable RTSS CAN module
   to communicate with user-space applications using
   SocketCAN APIs.
   
   Signed-off-by: q-AnupKulkarni <anupkulk@qti.qualcomm.com>
   

Reproduce locally:

cd /path/to/kernel
git log -1 --format=%s 028d9b615b488836205e0ed11d9783fd1eafdff6
# Should show: QCLINUX: arm64: qcom.config: Enable VCAN support

# To fix, amend the commit:
git commit --amend
# Change subject line to remove QCLINUX: prefix

Verdict

1 blocker to fix: Remove the QCLINUX: prefix from the commit subject. The patch is otherwise clean (checkpatch passed, no code/DT/UAPI changes to validate). Once the subject is corrected to use a standard prefix (or no prefix for downstream config changes), the PR will be ready to merge.