Skip to content

FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD#1425

Open
Jianping (Jianping-Li) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs615from
Jianping-Li:talos-dt
Open

FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD#1425
Jianping (Jianping-Li) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs615from
Jianping-Li:talos-dt

Conversation

@Jianping-Li

@Jianping-Li Jianping (Jianping-Li) commented Jun 29, 2026

Copy link
Copy Markdown

Reserve memory region for audio PD dynamic loading and remote heap requirements. Add the required VMID list for memory ownership transfers.

Link: https://lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/
CRs-Fixed: 4580745
qli-2.0 GA Critical Fix

@qcomlnxci qcomlnxci requested review from a team, Kaushal Kumar (quic-kaushalk), Salendarsingh Gaud (sgaud-quic) and Trilok Soni (trsoni) and removed request for a team June 29, 2026 06:30
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353109214

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/talos.dtsi Yes PR modifies talos.dtsi which conflicts with existing changes from topic/tech/all/dt/qcs615 branch already merged into the integration baseline

Verdict

This is a merge conflict, not a compilation error. The PR cannot be automatically merged with the current integration branch due to conflicting changes in talos.dtsi.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353109214

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/talos.dtsi No PR modifies the same file (talos.dtsi) that was already modified by topic branch topic/tech/all/dt/qcs615 during integration. The conflict occurs because both changes touch overlapping or adjacent regions of the device tree.

Verdict

This is not a compilation error. The build failed during the merge phase due to a merge conflict between PR #1425 and the pre-existing topic branch topic/tech/all/dt/qcs615. The PR itself does not introduce compilation errors; it introduces a merge conflict with existing integration branch content.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1425 — validate-patch

PR: #1425

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — Link tag present in commit message pointing to lore.kernel.org
  2. Lore link matches PR commits: N/A — Cannot fetch upstream patch (network restricted, future-dated link)
  3. Upstream patch status: In review — FROMLIST prefix indicates posted to mailing list but not yet merged
  4. PR present in qcom-next: Not checked — validation scope limited to patch correctness per constraints
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1425 - FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Upstream commit: https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore link dated 2026-04-24 (future), network restricted
Body preserves rationale Clear description of memory region purpose for audio PD
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ⚠️ Cannot verify without upstream comparison
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream, not backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos.dtsi Well-formed DT changes: adds SCM header, memory region, fastrpc properties

Issues

  • Lore link verification blocked: The Link tag references a message dated 2026-04-24, which is in the future relative to the commit date (2026-05-19). This temporal inconsistency suggests either the lore link is a placeholder/test data, or there's a date mismatch. Cannot fetch to verify diff faithfulness.
  • FROMLIST prefix: Indicates patch is from mailing list but not yet merged upstream. This is appropriate for patches under review.

Verdict

Cannot fully validate without upstream comparison due to network restrictions and future-dated lore link. Patch structure and commit message format follow kernel conventions. Recommend manual verification of lore link and diff comparison when network access is available.

Final Summary

  1. Lore link present: Yes — Link tag present in commit message pointing to lore.kernel.org
  2. Lore link matches PR commits: N/A — Cannot fetch upstream patch (network restricted, future-dated link)
  3. Upstream patch status: In review — FROMLIST prefix indicates posted to mailing list but not yet merged
  4. PR present in qcom-next: Not checked — validation scope limited to patch correctness per constraints

@qlijarvis

Copy link
Copy Markdown

PR #1425 — checker-log-analyzer

PR: #1425
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353109447

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict with topic/tech/all/dt/qcs615
dt-binding-check Merge conflict with topic/tech/all/dt/qcs615
dtb-check Merge conflict with topic/tech/all/dt/qcs615
sparse-check Merge conflict with topic/tech/all/dt/qcs615
check-uapi-headers Merge conflict with topic/tech/all/dt/qcs615
check-patch-compliance Merge conflict with topic/tech/all/dt/qcs615
tag-check N/A Not applicable (no log)
qcom-next-check FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1425 - FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353109447

Checker Result Summary
checkpatch Merge conflict with topic/tech/all/dt/qcs615
dt-binding-check Merge conflict with topic/tech/all/dt/qcs615
dtb-check Merge conflict with topic/tech/all/dt/qcs615
sparse-check Merge conflict with topic/tech/all/dt/qcs615
check-uapi-headers Merge conflict with topic/tech/all/dt/qcs615
check-patch-compliance Merge conflict with topic/tech/all/dt/qcs615
tag-check N/A Not applicable (no log)
qcom-next-check FROMLIST: prefix present

❌ All Checkers (Merge Conflict)

Root cause: PR #1425 conflicts with existing changes in topic/tech/all/dt/qcs615 when merging into the integration branch based on baseline 19b282f417584cfe14ce6a262122c51553d026ec.

Failure details:

2026-06-29T06:47:22.2827876Z Auto-merging arch/arm64/boot/dts/qcom/talos.dtsi
2026-06-29T06:47:22.2828756Z CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/talos.dtsi
2026-06-29T06:47:22.3437993Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-29T06:47:22.3552263Z Merge failed or conflicts detected. Aborting merge.
2026-06-29T06:47:22.4789258Z ##[error]Process completed with exit code 3.

The CI workflow attempts to:

  1. Create an integration branch from baseline 19b282f417584cfe14ce6a262122c51553d026ec
  2. Merge topic branch topic/tech/all/dt/qcs615 (succeeds)
  3. Merge PR FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD #1425 (fails with conflict in arch/arm64/boot/dts/qcom/talos.dtsi)

Analysis:
This PR adds a new adsp_rpc_remote_heap_mem memory region and references it in the fastrpc node. The conflict likely occurs because:

  • The topic branch topic/tech/all/dt/qcs615 has already modified the same sections of talos.dtsi (reserved-memory or fastrpc node)
  • Both changes touch overlapping or adjacent lines in the device tree

Fix:
The PR author needs to rebase this PR on top of the current integration state that includes topic/tech/all/dt/qcs615. Steps:

  1. Fetch the latest topic branch:

    git fetch origin topic/tech/all/dt/qcs615
  2. Rebase the PR branch:

    git rebase origin/topic/tech/all/dt/qcs615
  3. Resolve conflicts in arch/arm64/boot/dts/qcom/talos.dtsi:

    • Open the file and look for conflict markers (<<<<<<<, =======, >>>>>>>)
    • Manually merge the changes, ensuring both the topic branch changes and this PR's changes are preserved
    • The new adsp_rpc_remote_heap_mem node should be added to the reserved-memory section
    • The memory-region and qcom,vmids properties should be added to the fastrpc node
  4. Stage resolved files and continue:

    git add arch/arm64/boot/dts/qcom/talos.dtsi
    git rebase --continue
  5. Force-push the rebased branch:

    git push --force-with-lease

Reproduce locally:

# Clone the kernel-topics repo
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics

# Fetch the PR
git fetch origin pull/1425/head:pr-1425
git checkout pr-1425

# Attempt to rebase on the topic branch
git fetch origin topic/tech/all/dt/qcs615
git rebase origin/topic/tech/all/dt/qcs615

# Conflict will appear in arch/arm64/boot/dts/qcom/talos.dtsi

Verdict

1 blocker to fix: Merge conflict in arch/arm64/boot/dts/qcom/talos.dtsi must be resolved by rebasing on topic/tech/all/dt/qcs615. Once rebased and force-pushed, all checkers should pass (assuming the patch itself is clean).

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28439510890

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing integration conflict between baseline (qcom-next) and topic branch (tech/all/dt/qcs615)
2 100+ additional merge conflicts Various files across kernel tree No Widespread integration conflicts between baseline and topic branch

Verdict

All errors are pre-existing integration issues, not introduced by this PR. The PR only modifies device tree files for qcs615-ride and talos platforms. The build failure occurred during the automerge step when attempting to integrate the topic branch with the baseline, encountering 101 merge conflicts in files unrelated to the PR changes.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28439510890

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge arch/arm64/boot/dts/qcom/qcs615-ride.dts Yes PR modifies qcs615-ride.dts (adds PSCI reboot-mode), conflicts with concurrent changes in integration baseline
2 Merge conflict during automerge arch/arm64/boot/dts/qcom/talos.dtsi Yes PR modifies talos.dtsi in 8 separate commits (adds psci label, cdsp cooling, thermal zones), conflicts with concurrent changes in integration baseline

Verdict

This is NOT a compilation failure. The build failed during the automerge phase before compilation could begin. Both merge conflicts are in files modified by this PR and are caused by concurrent changes in the integration baseline that conflict with PR changes.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1425 — validate-patch

PR: #1425

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: Yes — all 12 FROMLIST commits have valid lore.kernel.org links; 1 PENDING commit correctly has no lore link
  2. Lore link matches PR commits: Cannot verify (network restricted) — but all links follow proper format and point to appropriate patch series
  3. Upstream patch status: FROMLIST (in review/pending merge) for 12 commits; PENDING (vendor-only, not yet posted) for 1 commit
  4. PR present in qcom-next:
    • ✅ Commits 1-11 present in qcom-next (verified by SHA)
    • ⚠️ Commits 12-13 not yet in qcom-next (485d21f, 129af3f not found) — likely newer patches pending integration
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1425
Upstream commits: Multiple FROMLIST patches from lore.kernel.org (12 commits) + 1 PENDING commit
Verdict: ✅ PASS

Commit Message Analysis

Commit Subject Status Notes
01/13 qcs615-ride: Add PSCI SYSTEM_RESET2 types FROMLIST prefix correct, lore link present, proper format
02/13 Enable cdsp qmi tmd devices for talos FROMLIST prefix correct, lore link present, proper format
03/13 talos: Add psci reboot-modes ⚠️ Author is Shivendra Pratap but first SOB is Song Xue - acceptable if co-developed
04/13 talos: Add GPR node, audio services, and MI2S1 TLMM pins FROMLIST prefix correct, lore link present, Reviewed-by present
05/13 talos-evk: Add sound card support with DA7212 codec FROMLIST prefix correct, lore link present, Reviewed-by present
06/13 talos-evk-som: Enable Adreno 612 GPU FROMLIST prefix correct, lore link present, proper format
07/13 talos: Add QSPI support FROMLIST prefix correct, lore link present, Reviewed-by present
08/13 qcs615-ride: Enable QSPI and NOR flash FROMLIST prefix correct, lore link present, Reviewed-by present
09/13 talos: enable video codec on Talos PENDING prefix correct, no lore link (as expected), proper format
10/13 qcs615-ride: fix sdhc_2 vqmmc-supply for UHS-I mode FROMLIST prefix correct, lore link present, proper format
11/13 talos: Add GEM_NOC interconnect for adreno SMMU FROMLIST prefix correct, lore link present, proper format
12/13 talos: Add label properties to CoreSight devices FROMLIST prefix correct, lore link present, Reviewed-by present
13/13 talos: Add memory-region for audio PD FROMLIST prefix correct, lore link present, proper format

Diff Analysis

All diffs are device tree changes for Qualcomm Talos (QCS615) platform. Changes include:

File Status Notes
arch/arm64/boot/dts/qcom/qcs615-ride.dts PSCI reboot modes, QSPI/NOR flash, SD card voltage fix
arch/arm64/boot/dts/qcom/talos.dtsi PSCI reboot modes, thermal, audio GPR/APM/PRM, QSPI, GPU SMMU, CoreSight labels, audio PD memory
arch/arm64/boot/dts/qcom/talos-evk.dts Sound card with DA7212 codec
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi GPU enablement
arch/arm64/boot/dts/qcom/talos-el2.dtso Video codec enablement in EL2 config

All diffs follow standard device tree conventions with proper indentation, node ordering, and property formatting.

Tag Hygiene

Check Status Note
Authorship preserved All commits have proper From: headers
Signed-off-by chain All commits have proper SOB chains
Link tags present All FROMLIST commits have lore.kernel.org links
Reviewed-by tags 7 commits have Reviewed-by tags from maintainers
FROMLIST/PENDING prefix All commits properly prefixed

Issues

Minor:

  • Commit 03/13: Author is "Shivendra Pratap" but first Signed-off-by is "Song Xue". This is acceptable if the patch was co-developed or picked up by Shivendra from Song's original work. The lore link should be checked to verify the original authorship matches the upstream submission.

No blocking issues found.

Verdict

Merge as-is. All commits follow proper kernel conventions with correct FROMLIST/PENDING prefixes, lore links where expected, proper authorship chains, and clean device tree changes. The minor authorship note on commit 3 is acceptable for co-developed patches.

Final Summary

  1. Lore link present: Yes — all 12 FROMLIST commits have valid lore.kernel.org links; 1 PENDING commit correctly has no lore link
  2. Lore link matches PR commits: Cannot verify (network restricted) — but all links follow proper format and point to appropriate patch series
  3. Upstream patch status: FROMLIST (in review/pending merge) for 12 commits; PENDING (vendor-only, not yet posted) for 1 commit
  4. PR present in qcom-next:
    • ✅ Commits 1-11 present in qcom-next (verified by SHA)
    • ⚠️ Commits 12-13 not yet in qcom-next (485d21f, 129af3f not found) — likely newer patches pending integration

@qlijarvis

Copy link
Copy Markdown

PR #1425 — checker-log-analyzer

PR: #1425
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28439511268

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict prevented execution
dt-binding-check Merge conflict prevented execution
dtb-check Merge conflict prevented execution
sparse-check Merge conflict prevented execution
check-uapi-headers Merge conflict prevented execution
check-patch-compliance Merge conflict prevented execution
tag-check ⏭️ Not applicable (FROMLIST commits)
qcom-next-check All commits properly tagged with FROMLIST:

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1425 - QCS615 and Talos DTS updates (13 patches)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28439511268

Checker Result Summary
checkpatch Merge conflict prevented execution
dt-binding-check Merge conflict prevented execution
dtb-check Merge conflict prevented execution
sparse-check Merge conflict prevented execution
check-uapi-headers Merge conflict prevented execution
check-patch-compliance Merge conflict prevented execution
tag-check ⏭️ Not applicable (FROMLIST commits)
qcom-next-check All commits properly tagged with FROMLIST:

❌ All Checkers (Merge Conflict)

Root cause: Merge conflict in arch/arm64/boot/dts/qcom/talos.dtsi when integrating PR #1425 with topic branch topic/tech/all/dt/qcs615

Failure details:

2026-06-30T11:17:38.4762698Z  ** Merging topic branch: topic/tech/all/dt/qcs615
2026-06-30T11:17:56.1549654Z fatal: refusing to merge unrelated histories
2026-06-30T11:17:56.2579532Z Merge failed, manual merge
...
2026-06-30T11:17:58.2547528Z Merging pr-1425 (no-commit)...
2026-06-30T11:17:59.2209208Z Auto-merging arch/arm64/boot/dts/qcom/talos.dtsi
2026-06-30T11:17:59.2209832Z CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/talos.dtsi
2026-06-30T11:17:59.2898003Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-30T11:17:59.3026085Z Merge failed or conflicts detected. Aborting merge.
2026-06-30T11:17:59.4258680Z ##[error]Process completed with exit code 3.

Analysis:

The PR modifies arch/arm64/boot/dts/qcom/talos.dtsi in multiple patches:

  • Patch 01/13: Adds psci: psci label to the psci node (line 563)
  • Patch 02/13: Adds cdsp cooling device nodes (around line 3768)
  • Patch 03/13: Likely adds more psci-related changes

The conflict occurs because:

  1. The topic branch topic/tech/all/dt/qcs615 already contains overlapping changes to talos.dtsi
  2. The PR's changes to the same file regions cannot be automatically merged
  3. All checker jobs depend on a successful merge, so they all fail at the merge step

Fix:

Option 1: Rebase the PR on top of the latest integration branch (Recommended)

# Fetch the latest topic branch
git fetch origin topic/tech/all/dt/qcs615

# Rebase your PR branch
git rebase origin/topic/tech/all/dt/qcs615

# Resolve conflicts in arch/arm64/boot/dts/qcom/talos.dtsi
# Edit the file to resolve conflict markers
git add arch/arm64/boot/dts/qcom/talos.dtsi
git rebase --continue

# Force push the rebased branch
git push --force-with-lease

Option 2: Coordinate with the topic branch owner

  • Contact the owner of topic/tech/all/dt/qcs615 to understand their changes
  • Determine if your changes should be merged into that topic branch first
  • Or wait for that topic branch to be merged before submitting this PR

Option 3: Split the PR

  • Separate patches that don't touch talos.dtsi into a different PR
  • Submit the talos.dtsi changes separately after resolving the conflict

Reproduce locally:

# Clone the kernel-topics repo
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics

# Fetch the PR
git fetch origin pull/1425/head:pr-1425
git checkout pr-1425

# Try to merge with the topic branch
git fetch origin topic/tech/all/dt/qcs615
git merge origin/topic/tech/all/dt/qcs615

# You should see the same conflict in arch/arm64/boot/dts/qcom/talos.dtsi

Verdict

❌ BLOCKED - 1 merge conflict must be resolved before checkers can run

The PR cannot be validated until the merge conflict in arch/arm64/boot/dts/qcom/talos.dtsi is resolved. All 6 checker jobs failed at the merge step before any actual validation could occur. Once the conflict is resolved and the PR is updated, the checkers will need to be re-run to validate the code quality, DT bindings, and patch compliance.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28489020922

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/talos.dtsi Yes PR modifies talos.dtsi which conflicts with baseline changes during automerge
2 100+ additional merge conflicts Various files (dt-bindings, drivers, etc.) No Pre-existing conflicts in the topic branch unrelated to this PR's changes

Verdict

The build failure is caused by merge conflicts during the integration phase, not compilation errors. The PR-modified file (talos.dtsi) has a merge conflict, but the PR itself is not responsible for the 100+ other conflicts in the topic branch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28489020922

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/talos.dtsi No Pre-existing conflict between PR branch and integration base; the PR modifies talos.dtsi which has conflicting changes in the integration branch

Verdict

This is not a compilation failure. The build failed during the merge phase before compilation began. The PR modifies arch/arm64/boot/dts/qcom/talos.dtsi, which has conflicting changes in the integration branch that need to be resolved before the build can proceed.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1425 — validate-patch

PR: #1425

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to v3 patch series at lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify — network restrictions prevent fetching upstream patch for byte-by-byte comparison; commit message and structure appear consistent with upstream submission

  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged to mainline; posted as v3 on 2026-06-29 (recent submission)

  4. PR present in qcom-next: No — git log search in /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel confirms this change is not yet in qcom-next branch

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1425 - arm64: dts: qcom: talos: Add memory-region for audio PD
Upstream commit: https://lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (cannot verify upstream diff due to network restrictions)

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; subject follows kernel DT conventions
Body preserves rationale Clear description of memory region purpose and VMID requirements
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Original author Ekansh Gupta preserved with proper Signed-off-by chain
Backport note (if applicable) N/A FROMLIST prefix indicates patch is from mailing list, not yet merged

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos.dtsi Adds SCM header, memory region node, and fastrpc properties; follows DT conventions

Commit Message Analysis

Subject: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD

  • ✅ Proper FROMLIST prefix indicating upstream submission status
  • ✅ Follows kernel DT subject format: arm64: dts: qcom: <board>: <action>
  • ✅ Concise and descriptive

Body:

  • ✅ Clear rationale: reserves memory for audio PD dynamic loading and remote heap
  • ✅ Explains VMID list purpose for memory ownership transfers
  • ✅ Includes Link tag pointing to v3 patch series on lore

Trailers:

  • ✅ Original author Signed-off-by: Ekansh Gupta
  • ✅ Additional Signed-off-by: Jianping Li (likely the integrator)
  • ✅ Link tag present with proper lore.kernel.org URL format

Diff Analysis

Changes made:

  1. Header addition (+#include <dt-bindings/firmware/qcom,scm.h>):

    • ✅ Required for QCOM_SCM_VMID_* constants used later
    • ✅ Inserted in alphabetical order among includes
  2. Memory region node (adsp_rpc_remote_heap_mem):

    • ✅ Proper DT node naming with label
    • compatible = "shared-dma-pool" is standard for shared memory
    • reusable property appropriate for dynamic allocation
    • alloc-ranges, alignment, and size properties properly formatted
    • ✅ 8MB size (0x800000) with 4MB alignment (0x400000) reasonable for audio heap
  3. Fastrpc node updates:

    • memory-region property references the new memory node
    • qcom,vmids property lists LPASS and ADSP_HEAP VMIDs
    • ✅ Multi-line VMID list properly indented

Code quality:

  • ✅ Proper DT syntax and formatting
  • ✅ Consistent indentation
  • ✅ No obvious errors or typos

Issues

None identified in commit message structure or diff formatting. The patch follows kernel devicetree conventions and Qualcomm-specific patterns for memory region and fastrpc configuration.

Verdict

Merge recommendation: Approve pending upstream acceptance verification

The patch is well-formed with proper commit message structure, clear rationale, and correct DT syntax. The FROMLIST prefix correctly indicates this is from an upstream submission (v3 series posted 2026-06-29). However, due to network restrictions, I cannot:

  • Fetch and compare the actual upstream patch to verify diff faithfulness
  • Check the current upstream review status or acceptance state

What was verified:

  • ✅ Commit message follows kernel conventions
  • ✅ Authorship and sign-off chain preserved
  • ✅ Link tag present with proper lore URL
  • ✅ Diff follows DT coding style and Qualcomm patterns
  • ✅ Not present in qcom-next (checked via git log)

What needs manual verification:

  • ⚠️ Upstream patch diff matches PR patch exactly (requires network access to lore)
  • ⚠️ Upstream review status (accepted/pending/changes requested)

Final Summary

  1. Lore link present: Yes — Link tag points to v3 patch series at lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify — network restrictions prevent fetching upstream patch for byte-by-byte comparison; commit message and structure appear consistent with upstream submission

  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged to mainline; posted as v3 on 2026-06-29 (recent submission)

  4. PR present in qcom-next: No — git log search in /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel confirms this change is not yet in qcom-next branch

@qlijarvis

Copy link
Copy Markdown

PR #1425 — checker-log-analyzer

PR: #1425
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28489021060

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - merge failure prevented execution
dt-binding-check ⏭️ Skipped - merge failure prevented execution
dtb-check ⏭️ Skipped - merge failure prevented execution
sparse-check ⏭️ Skipped - merge failure prevented execution
check-uapi-headers ⏭️ Skipped - merge failure prevented execution
check-patch-compliance ⏭️ Skipped - merge failure prevented execution
tag-check N/A Not applicable - FROMLIST prefix present
qcom-next-check FROMLIST: prefix correctly used

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1425 - FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28489021060

Checker Result Summary
checkpatch ⏭️ Skipped - merge failure prevented execution
dt-binding-check ⏭️ Skipped - merge failure prevented execution
dtb-check ⏭️ Skipped - merge failure prevented execution
sparse-check ⏭️ Skipped - merge failure prevented execution
check-uapi-headers ⏭️ Skipped - merge failure prevented execution
check-patch-compliance ⏭️ Skipped - merge failure prevented execution
tag-check N/A Not applicable - FROMLIST prefix present
qcom-next-check FROMLIST: prefix correctly used

❌ CI Infrastructure Failure (All Checkers)

Root cause: The PR branch has an unrelated git history that cannot be merged with the baseline qcom-next branch, causing all checker jobs to fail during the integration step before any actual checks could run.

Failure details:

2026-07-01T02:36:00.3242395Z  ** Merging topic branch: topic/tech/all/dt/qcs615
2026-07-01T02:36:18.2892687Z fatal: refusing to merge unrelated histories
2026-07-01T02:36:18.3943795Z Merge failed, manual merge
...
2026-07-01T02:36:19.4059895Z Merging pr-1425 (no-commit)...
2026-07-01T02:36:38.7426284Z fatal: refusing to merge unrelated histories
2026-07-01T02:36:38.8515755Z Merge failed or conflicts detected. Aborting merge.
2026-07-01T02:36:38.8534109Z fatal: There is no merge to abort (MERGE_HEAD missing).
2026-07-01T02:36:38.8553730Z ##[error]Process completed with exit code 3.

This error occurred in all six checker jobs:

  • checker__checkpatch____checker.txt
  • checker__dt-binding-check____checker.txt
  • checker__dtb-check____checker.txt
  • checker__sparse-check____checker.txt
  • checker__check-uapi-headers____checker.txt
  • checker__check-patch-compliance____checker.txt

Analysis:

The CI workflow attempts to:

  1. Create an integration branch based on baseline commit 19b282f417584cfe14ce6a262122c51553d026ec (qcom-next)
  2. Merge topic branch topic/tech/all/dt/qcs615 into the integration branch
  3. Merge the PR commits on top

Both merge operations fail with fatal: refusing to merge unrelated histories, which indicates that:

  • The topic branch topic/tech/all/dt/qcs615 does not share a common ancestor with the baseline
  • The PR branch itself also lacks a common git history with the baseline

This is a branch structure/history issue, not a code quality problem. The patch content itself appears valid:

  • Adds a memory region for audio PD (ADSP remote heap)
  • Includes proper dt-bindings header for SCM VMIDs
  • Uses correct FROMLIST: prefix with lore link
  • Has proper sign-offs

Fix:

The PR author needs to rebase the branch onto the correct baseline. Choose one of these approaches:

Option 1: Rebase onto qcom-next (Recommended)

# In the PR branch
git fetch https://github.com/qualcomm-linux/kernel.git qcom-next
git rebase FETCH_HEAD
git push --force-with-lease

Option 2: Recreate the branch with proper history

# Start from qcom-next
git fetch https://github.com/qualcomm-linux/kernel.git qcom-next
git checkout -b topic/tech/all/dt/qcs615-rebased FETCH_HEAD

# Cherry-pick the commit
git cherry-pick 7bfdc24c73ab3a97b56c21b67d9959834099013e

# Force-push to update the PR
git push --force-with-lease origin topic/tech/all/dt/qcs615-rebased:topic/tech/all/dt/qcs615

Option 3: Use --allow-unrelated-histories (Not Recommended)

If the branch intentionally has a separate history, the CI workflow needs to be updated to use:

git merge --allow-unrelated-histories <branch>

However, this is typically not the correct solution for kernel topic branches.

Reproduce locally:

# Clone the baseline
git clone https://github.com/qualcomm-linux/kernel.git -b qcom-next
cd kernel

# Try to merge the topic branch
git fetch https://github.com/qualcomm-linux/kernel-topics.git refs/pull/1425/head:pr-1425
git merge pr-1425
# Expected: fatal: refusing to merge unrelated histories

Verdict

CI infrastructure blocker: The PR cannot be tested by the checker CI until the branch history is fixed. The patch content appears valid, but the branch must be rebased onto qcom-next before the checkers can run. Once rebased, re-run the CI to verify checkpatch, dt-binding-check, and dtb-check pass.

Action required: PR author must rebase the branch onto the correct baseline (qcom-next) and force-push to update the PR.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/dt/qcs615'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/dt/qcs615

Reserve memory region for audio PD dynamic loading and remote heap
requirements. Add the required VMID list for memory ownership
transfers.

Link: https://lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28491115519

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/talos.dtsi Indirect PR modifies talos.dtsi which conflicts with other changes in the integration branch
2 105 additional merge conflicts Various files No Pre-existing conflicts in the integration branch unrelated to this PR's changes

Verdict

This is not a compilation failure. The build failed during the merge/integration phase before compilation began. The PR itself introduces changes to talos.dtsi that conflict with other pending changes in the integration branch. The remaining 105 conflicts are unrelated to this PR.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1425

PR: #1425
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28491115519

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/talos.dtsi Yes PR modifies talos.dtsi which conflicts with changes in baseline qcom-next branch
2 Merge conflicts (multiple files) Various files (60+ conflicts) No Pre-existing conflicts between topic branch tech/all/dt/qcs615 and baseline qcom-next, unrelated to this PR's changes

Verdict

The build failed during the merge phase before compilation. The PR introduces changes to talos.dtsi that conflict with the baseline. Additionally, 60+ pre-existing merge conflicts exist in files not touched by this PR, indicating the topic branch needs rebasing against qcom-next.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1425 — validate-patch

PR: #1425

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Yes - v3 patch series link provided in commit message
  2. Lore link matches PR commits: Cannot verify - lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged to mainline
  4. PR present in qcom-next: No - checked origin/qcom-next branch; patch not present in integration tree
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1425 - arm64: dts: qcom: talos: Add memory-region for audio PD
Upstream commit: https://lore.kernel.org/all/20260629-talos-remoteheap-v3-1-4e23366c9196@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (cannot verify upstream diff match due to network restrictions)

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable; subject format is correct
Body preserves rationale Clear description of memory region purpose and VMID requirements
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Original author Ekansh Gupta preserved; co-author Jianping Li added
Backport note (if applicable) N/A FROMLIST prefix indicates patch is from mailing list, not yet upstream

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos.dtsi ⚠️ Cannot verify against upstream - network restricted; structure looks correct

Issues

  • Cannot verify upstream match: Network access to lore.kernel.org is restricted, preventing direct comparison of the PR patch against the upstream v3 patch series
  • Date discrepancy: Patch date is May 19, 2026, but lore link references June 29, 2026 (20260629) - the patch appears to predate the upstream posting, which is unusual for a FROMLIST patch
  • Co-author addition: Jianping Li added as second Signed-off-by; this is acceptable if they are the integrator, but should match upstream if this is a direct backport

Verdict

Cannot fully validate due to network restrictions. Patch structure and format appear correct, but the date inconsistency (patch dated May 19, lore link dated June 29) suggests this may be a pre-submission version or the dates need reconciliation.

Final Summary

  1. Lore link present: Yes - v3 patch series link provided in commit message
  2. Lore link matches PR commits: Cannot verify - lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged to mainline
  4. PR present in qcom-next: No - checked origin/qcom-next branch; patch not present in integration tree

@qlijarvis

Copy link
Copy Markdown

PR #1425 — checker-log-analyzer

PR: #1425
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28491115573

Checker Result Summary
Checker Result Summary
checkpatch Merge failure: unrelated histories
dt-binding-check Merge failure: unrelated histories
dtb-check Merge failure: unrelated histories
sparse-check Merge failure: unrelated histories
check-uapi-headers Merge failure: unrelated histories
check-patch-compliance Merge failure: unrelated histories
tag-check N/A Not executed due to merge failure
qcom-next-check ⏭️ FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1425 - FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28491115573

Checker Result Summary
checkpatch Merge failure: unrelated histories
dt-binding-check Merge failure: unrelated histories
dtb-check Merge failure: unrelated histories
sparse-check Merge failure: unrelated histories
check-uapi-headers Merge failure: unrelated histories
check-patch-compliance Merge failure: unrelated histories
tag-check N/A Not executed due to merge failure
qcom-next-check ⏭️ FROMLIST: prefix present

❌ All Checkers (Infrastructure Failure)

Root cause: Git merge failure during CI setup - the topic branch topic/tech/all/dt/qcs615 and PR #1425 both have unrelated git histories that cannot be merged into the qcom-next baseline (commit 19b282f41758, Linux 7.1).

Failure details:

2026-07-01T03:36:01.0454356Z  ** Merging topic branch: topic/tech/all/dt/qcs615
2026-07-01T03:36:19.6098808Z fatal: refusing to merge unrelated histories
2026-07-01T03:36:20.0306671Z Fetching PR #1425 from https://github.com/qualcomm-linux/kernel-topics.git...
2026-07-01T03:36:20.7155792Z Merging pr-1425 (no-commit)...
2026-07-01T03:36:40.6525577Z fatal: refusing to merge unrelated histories
2026-07-01T03:36:40.7651607Z Merge failed or conflicts detected. Aborting merge.
2026-07-01T03:36:40.7689225Z ##[error]Process completed with exit code 3.

Analysis:
This is not a code quality issue. The CI workflow attempts to:

  1. Create an integration branch based on qcom-next (Linux 7.1 baseline)
  2. Merge topic branch topic/tech/all/dt/qcs615 into it
  3. Merge PR FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD #1425 on top

Both merges fail because the branches have completely different git histories with no common ancestor. This typically happens when:

  • The topic branch topic/tech/all/dt/qcs615 was created from a different base than qcom-next
  • The PR branch was created from a different base or rebased onto an incompatible history
  • The branch history was rewritten (force-pushed) after the PR was created

Fix:

Option 1: Rebase the PR onto the correct base (Recommended)

# In the PR branch
git fetch origin qcom-next
git rebase origin/qcom-next
git push --force-with-lease

Option 2: Verify and fix the topic branch base
The topic branch topic/tech/all/dt/qcs615 needs to be based on qcom-next or share a common ancestor. Check with the branch maintainer to ensure it's properly integrated.

Option 3: Use --allow-unrelated-histories (Not recommended for production)
This would require CI workflow changes and is generally not advisable as it can create merge conflicts and history issues.

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git fetch origin qcom-next
git checkout qcom-next
git fetch https://github.com/qualcomm-linux/kernel-topics.git refs/pull/1425/head:pr-1425
git merge pr-1425
# Will fail with: fatal: refusing to merge unrelated histories

Verdict

CI infrastructure failure - PR cannot be tested until git history issue is resolved.

The patch content itself (adding memory-region for audio PD in talos.dtsi) appears valid based on the diff, but no code quality checks could run because the merge failed during CI setup.

Action required: The PR author or maintainer must rebase this PR onto the correct base branch (qcom-next or ensure the topic branch topic/tech/all/dt/qcs615 is properly integrated) before checkers can validate the code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants