Skip to content

QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd#1415

Open
Vishal Verma (vishverm-qli) wants to merge 66 commits into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:glymur-dt-change
Open

QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd#1415
Vishal Verma (vishverm-qli) wants to merge 66 commits into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:glymur-dt-change

Conversation

@vishverm-qli

@vishverm-qli Vishal Verma (vishverm-qli) commented Jun 25, 2026

Copy link
Copy Markdown

Enable camera sensors og0va1b on the Glymur CRD platform.

Adds required DT updates to support sensor bring-up and probe on Glymur crd board.

CRs-Fixed: 4590425

Chandan Jha (cjha01) and others added 30 commits April 29, 2026 15:03
Add the camera DT binding header, which will be utilized by the
camera downstream drivers and DTSI files.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add CAMX overlay dts file for lemans boards.

This change also enables the compilation of the
CAMX overlay on Lemans boards.

Co-developed-by: Vikram Sharma <vikramsa@qti.qualcom.com>
Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add CAMX overlay dts file for rb3gen2 vision mezzanine board.

This change also enables the compilation of the CAMX overlay
for Kodiak rb3gen2 vision mezzanine board.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add CAMX overlay dts file for Monaco boards.

This change also enables the compilation of the CAMX overlay
for Monaco boards.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
The camera firmware size for IoT variant qcs8300 SoC is more than
5MB. Update the PIL memory region size of camera to 7MB to accomodate
the same.

Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
- Fix the indentation issue.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
- Fix the indentation issue.
- Update DT clock property name after clock.
- Short DT nodes.
- Fix indexing issue.
- Update gpios shared pin.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
- Fix the indentation issue.
- Update DT clock property name after clock.
- Shorted DT nodes.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add the pil camera carveout region based on v2 memory map.

Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Add CAMX overlay dts file for Talos boards.

This change also enables the compilation of the
CAMX overlay on Talos boards.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add two new AHB bandwidth levels for the camnoc path and update
cam-ahb-num-cases accordingly. This ensures that the DT reflects
the full set of supported interconnect bandwidth cases.

Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
Disabled vreg_cam1_2p8 regulator to free GPIOs.

Signed-off-by: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Enable imx577 sensor on lemans boards from slot0 to slot3.

Signed-off-by: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
Add camx overlay for talos EVK baord.

Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
…emans

Adds labels to cam-cpas and cam-icp nodes and changes
enable-secure-qos-update from boolean to explicit.

This change is required for KVM support.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
…onaco

Adds labels to cam-cpas and cam-icp nodes and changes
enable-secure-qos-update from boolean to explicit.

This change is required for KVM support.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add camx el2 DT overlay for lemans platforms.

The overlay updates the ICP firmware node with Secure SMMU SID
and disables secure QoS updates for CPAS in EL2/KVM configurations.

Wire up the new overlay-built DTBs in the qcom DT Makefile so the
corresponding *-camx-el2.dtb targets are generated.

Co-developed-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
Add DT labels to sensor nodes in the Lemans and Kodiak DTSI
files to enable phandle references.
Monaco changes are already handled.

Signed-off-by: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
Fix a typo in the camx EL2 device tree by removing comments all
together. The mistake was masked by a later comment terminator.

Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
Add camx el2 DT overlay for lemans platforms.

The overlay updates the ICP firmware node with Secure SMMU SID
and disables secure QoS updates for CPAS in EL2/KVM configurations.

Wire up the new overlay-built DTBs in the qcom DT Makefile so the
corresponding *-camx-el2.dtb targets are generated.

Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
Add CAMX overlay dts file for Hamoa boards.

This change also enables the compilation of the CAMX overlay
for Hamoa boards.

Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
Rename the hamoa camera DTBs variable to match the
hamoa-camera-camx DTB target naming and improve consistency
with existing Makefile conventions.

Fixes: 9041882 ("QCLINUX: arm64: dts: qcom: Add hamoa camx overlay
dts")
Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
Add an overlay devicetree for Lemans EVK for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Add an overlay devicetree for Monaco EVK for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Add an overlay devicetree for Rb3Gen2 for temporary enablement of the
QPS615 PCIE switch's 10GbE and 2.5Gbe ethernet ports.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
… phy-vreg

The staging overlay used a bare "/ {" root node block to define the
qep_vreg and aqr_vreg fixed regulators.  In a DT overlay, a bare "/ {"
creates a new root fragment that is not merged into the base tree's
root node; as a result the regulator nodes are never instantiated and
the tc956x driver cannot resolve the phy-supply phandle, leading to a
failed MDIO probe:

  tc956x_pci-eth 0001:05:00.1: No PHY found

Replace "/ {" with the overlay-correct "&{/} {" syntax so that the
fragment is properly applied as an amendment to the base device-tree
root node.  This ensures the regulator nodes are present at boot and
the PHY powers up correctly.

Fixes: 00ba37e ("PENDING: arm64: dts: qcom: rb3gen2: add overlay for QPS615 ethernet")
Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Chandan Jha (cjha01) and others added 12 commits June 3, 2026 15:01
Update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add CAMX overlay dts file for Glymur crd  boards.

This change also enables the compilation of the CAMX overlay
for Glymur crd boards.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Added IFE Lite nodes to CPAS to enable proper voting on these
paths.

Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
vreg_cam0_2p8 and vreg_cam2_2p8 are not used on the Monaco EVK board.
Disable them to prevent unintended regulator enablement.

Signed-off-by: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
Add IPCC_CLIENT_RTSS0/1/2/3 client ID definitions (27-30) to
the qcom-ipcc dt-bindings header for use by the RTSS Mailbox
device tree overlay.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Add lemans-rtss-mb.dtso overlay for Lemans platform providing:
  - ipcc_computeL1: IPCC Compute-L1 controller
  - rtss_mailbox: RTSS Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Add monaco-rtss-mb.dtso overlay for Monaco platform providing:
- ipcc_computeL1: IPCC Compute-L1 controller
- rtss_mailbox: RTSS Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Reduce the ICP iova-region-len to keep the IO region within
the valid 4GB addressable range and avoid overflow.

This ensures proper IOVA mapping and prevents potential
address boundary violations during camera memory
configuration.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Enable camera sensors OV08X on the Glymur CRD platform.

Adds required DT updates to support sensor bring-up and
probe on Glymur crd board.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Move the common Hamoa staging overlay contents into x1-staging.dtsi
so they can be shared across X1 platforms. Keep hamoa-staging.dtso
as a thin wrapper around the shared include and add purwa-staging.dtso
to build an identical staging overlay for Purwa.

Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
…debug block

Add the following devices that are part of the APSS debug block to
enable debug features, including ETM, replicator, funnel, and
TMC ETF.

Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Add hamoa-camera-regulators.dtsi to define the PM8010_M PMIC LDO
regulators needed by camera sensor drivers, and include it in both
hamoa-evk-camx.dtso and purwa-evk-camx.dtso.

L1M supplies the IMX688 AON core domain (DVDD). It is fed by S5J
and supports an output range of 1056-1200 mV.

L2M supplies the IMX766 core domain (DVDD). It is fed by S5J and
supports an output range of 1152-1200 mV.

L3M supplies the IMX766 analog domain and OV sensor I/O (AVDD2,
DOVDD). It is fed by S4C and is fixed at 1808 mV.

L4M supplies the IMX688 AON I/O domain and IMX766 I/O domain
(DOVDD). It is fed by S4C and is fixed at 1808 mV.

L5M supplies the IMX766 VCM. It is fed by BOB1 and is fixed at
2960 mV.

L6M supplies the IMX688 AON analog domain (AVDD2). It is fed by
S4C and is fixed at 1808 mV.

L7M supplies the camera analog domain (AVDD). It is fed by BOB1
and is fixed at 2912 mV.

Signed-off-by: Tingguo Cheng <tingguoc@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, aiquny, Nicolas Dechesne (ndechesne) and Tingwei Zhang (quic-tingweiz) and removed request for a team June 29, 2026 05:31
@qlijarvis

Copy link
Copy Markdown

PR #1415 — validate-patch

PR: #1415

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required

  2. Lore link matches PR commits: N/A — no lore link to compare against

  3. Upstream patch status: N/A — vendor-only change, not posted upstream

  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1415 - Enable og0va1b camera sensor on glymur crd
Upstream commit: N/A (vendor-only QCLINUX: patches)
Verdict: ⚠️ PARTIAL

Commit Message

Patch 1/2: QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd

Check Status Note
Subject matches upstream N/A Vendor-only commit (QCLINUX: prefix)
Body preserves rationale Clear description of camera sensor enablement
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Author: Vishal Verma vishverm@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Patch 2/2: Update glymur-camera-sensor.dtsi

Check Status Note
Subject matches upstream Generic subject; missing QCLINUX: prefix and subsystem tag
Body preserves rationale ⚠️ Minimal description; lacks context on why offset changed
Fixes tag present/correct Should reference commit 1/2 with Fixes: tag
Authorship preserved Author: Vishal Verma vishverm@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

Patch 1/2:

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi Adds og0a1b sensor node and shared pinctrl config

Patch 2/2:

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi ⚠️ Changes pinctrl reference from phandle to GPIO number; removes orphaned pinctrl-names

Issues

Patch 2/2 commit message issues:

  1. Missing subsystem prefix: Subject should be QCLINUX: arm64: dts: qcom: Fix shared pinctrl gpio offset in glymur camera sensor to match kernel conventions and patch 1/2 style

  2. Generic subject: "Update glymur-camera-sensor.dtsi" is too vague; should describe what is being fixed

  3. Missing Fixes: tag: This patch fixes an issue introduced in patch 1/2. Should include:

    Fixes: 3a8ebdf21e60 ("QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd")
    
  4. Insufficient rationale: Commit body should explain:

    • Why the change from phandle <&cam_sensor_mclk4_active> to GPIO number <760> is needed
    • What problem this solves (e.g., binding requirement, hardware constraint)
    • Why pinctrl-names was removed from cam-sensor0

Technical concerns:

  1. Hardcoded GPIO number: Using <760> instead of a phandle or symbolic constant reduces maintainability and may not align with DT best practices

  2. Incomplete cleanup: Patch 1/2 removed pinctrl properties from cam-sensor0 but left pinctrl-names; patch 2/2 removes it. These should have been handled together in patch 1/2

Verdict

Patch 1/2 is acceptable as a vendor feature addition. Patch 2/2 requires commit message improvements (proper subject prefix, Fixes: tag, better rationale) and should ideally be squashed into patch 1/2 since it fixes an issue introduced in the same series.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required

  2. Lore link matches PR commits: N/A — no lore link to compare against

  3. Upstream patch status: N/A — vendor-only change, not posted upstream

  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1415 — checker-log-analyzer

PR: #1415
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28350807037

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 WARNING: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check 3 NEW errors in qcom,cam-sensor1 node
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Both commits missing required subject prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1415 - Enable og0va1b camera sensor on glymur crd
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28350807037

Checker Result Summary
checkpatch ⚠️ 1 WARNING: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check 3 NEW errors in qcom,cam-sensor1 node
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Both commits missing required subject prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

❌ dtb-check

Root cause: The newly added qcom,cam-sensor1 node in arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi:44 violates DT schema validation rules.

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: 
  qcom,cci1@ac16000 (qcom,cci): qcom,cam-sensor1: 'ranges' is a required property

arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: 
  /soc@0/qcom,cci1@ac16000/qcom,cam-sensor1: failed to match any schema with compatible: ['qcom,cam-sensor']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: 
  qcom,cam-sensor1 (qcom,cam-sensor): gpio-req-tbl-label: b'CAM_MCLK4\x00CAMIF_RESET0\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'

Fix:

Three issues need to be addressed in the qcom,cam-sensor1 node:

  1. Missing ranges property: Add ranges; to the node (required by the parent qcom,cci binding)
  2. Undocumented compatible: The qcom,cam-sensor compatible string has no DT binding schema (also flagged by checkpatch)
  3. Invalid property type: The gpio-req-tbl-label property format doesn't match the expected schema type

Recommended actions:

  • Add ranges; property to the qcom,cam-sensor1 node
  • Either add a proper DT binding schema for qcom,cam-sensor in Documentation/devicetree/bindings/, or use an existing documented compatible string
  • Review and fix the gpio-req-tbl-label property format to match the schema expectations

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/glymur-crd-camx.dtb

❌ check-patch-compliance

Root cause: Both commits in the PR lack the required subject prefix for the kernel-topics repository.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd
Commit summary does not start with a required prefix

Checking commit: Update glymur-camera-sensor.dtsi
Commit summary does not start with a required prefix

Fix:

Reword commit subjects to include proper prefixes. For device tree changes in topic branches, acceptable prefixes include:

  • FROMLIST: - for patches submitted to upstream mailing lists
  • UPSTREAM: - for patches already merged upstream
  • BACKPORT: - for backported patches
  • QCLINUX: - appears to be used but may not be in the allowed list

Recommended actions:

  1. For commit 1: The subject already has QCLINUX: prefix but the checker rejected it. Verify the allowed prefix list in the repository's compliance rules. If QCLINUX: is not allowed, change to an appropriate prefix.
  2. For commit 2: Change "Update glymur-camera-sensor.dtsi" to a more descriptive subject with proper prefix, e.g., "QCLINUX: arm64: dts: qcom: glymur: Fix shared pinctrl gpio offset"

⚠️ checkpatch

Root cause: The qcom,cam-sensor compatible string used in the new camera sensor node is not documented in DT bindings.

Failure details:

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#37: FILE: arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi:45:
+		compatible = "qcom,cam-sensor";

Fix:

Add a device tree binding document for qcom,cam-sensor in Documentation/devicetree/bindings/media/ or use an existing documented compatible string.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git HEAD~2..HEAD

Verdict

3 blockers must be fixed before merge:

  1. dtb-check failures - Add missing ranges property, document the compatible string, and fix gpio-req-tbl-label format
  2. check-patch-compliance failures - Add proper subject prefixes to both commits
  3. checkpatch warning - Document the qcom,cam-sensor compatible string (related to dtb-check issue dummy change #2)

The PR introduces a new camera sensor node but violates DT schema validation rules and commit message conventions. All three issues are straightforward to fix with proper DT binding documentation and commit message updates.

@qcomlnxci qcomlnxci requested a review from a team June 29, 2026 06:19
@qlijarvis

Copy link
Copy Markdown

PR #1415 — validate-patch

PR: #1415

Verdict Issues Detailed Report
⚠️ 6 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1415 - Enable og0va1b camera sensor on glymur crd
Upstream commit: N/A (vendor-only QCLINUX patches)
Verdict: ⚠️ PARTIAL

Commit Message

Patch 1/2: QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd

Check Status Note
Subject matches upstream N/A Vendor-only commit (QCLINUX prefix)
Body preserves rationale Clear description of camera sensor enablement
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Author: Vishal Verma vishverm@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Patch 2/2: Update glymur-camera-sensor.dtsi

Check Status Note
Subject matches upstream Generic subject; missing QCLINUX prefix and proper description
Body preserves rationale ⚠️ Minimal description; lacks context on why offset changed
Fixes tag present/correct Should reference commit 1/2 with Fixes tag
Authorship preserved Author: Vishal Verma vishverm@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

Patch 1/2:

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi Adds new camera sensor node and shared pinctrl configuration

Patch 2/2:

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi ⚠️ Changes gpios-shared-pinctrl from phandle to numeric offset; removes orphaned pinctrl-names

Issues

Patch 2/2 commit message quality:

  • Missing QCLINUX prefix: Subject should be "QCLINUX: arm64: dts: qcom: glymur: Fix shared pinctrl gpio offset"
  • Generic subject: "Update glymur-camera-sensor.dtsi" doesn't follow kernel conventions; should describe what changed
  • Missing Fixes tag: This patch fixes an issue introduced in patch 1/2; should include:
    Fixes: 3a8ebdf21e60 ("QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd")
    
  • ⚠️ Insufficient rationale: Body should explain why the change from phandle reference <&cam_sensor_mclk4_active> to numeric offset <760> is necessary and correct

Technical concerns:

  • ⚠️ Hardcoded GPIO number: Using <760> instead of a phandle reference is unusual for DT; verify this is the correct approach for gpios-shared-pinctrl property
  • ⚠️ Removed pinctrl-names in patch 1: Patch 1 removes pinctrl-names from qcom,cam-sensor0 but patch 2 removes it again from the same node—suggests patch 1 may have incomplete changes

Verdict

Patch 1/2 is acceptable for vendor tree but patch 2/2 needs rework: improve commit message with proper prefix, descriptive subject, Fixes tag, and detailed rationale for the phandle-to-offset change.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1415 — checker-log-analyzer

PR: #1415
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28352643031

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check No changes in DT bindings
dtb-check Schema validation failures for new camera sensor node
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for tech/overlay/dt branch
qcom-next-check N/A Not applicable for tech/overlay/dt branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1415 - Enable og0va1b camera sensor on glymur crd
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28352643031

Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check No changes in DT bindings
dtb-check Schema validation failures for new camera sensor node
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for tech/overlay/dt branch
qcom-next-check N/A Not applicable for tech/overlay/dt branch

❌ checkpatch

Root cause: Commit 3a8ebdf uses undocumented DT compatible string qcom,cam-sensor

Failure details:

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#37: FILE: arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi:45:
+		compatible = "qcom,cam-sensor";

Fix: This is a vendor-specific camera sensor compatible string. If this is a Qualcomm downstream tree, this warning can typically be ignored as vendor camera bindings are often not upstreamed. If targeting upstream, you need to add a DT binding document in Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml.

Reproduce locally:

./scripts/checkpatch.pl --strict --git HEAD~2..HEAD

❌ dtb-check

Root cause: New qcom,cam-sensor1 node fails DT schema validation due to missing required ranges property and malformed gpio-req-tbl-label

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: qcom,cci1@ac16000 (qcom,cci): qcom,cam-sensor1: 'ranges' is a required property

arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: /soc@0/qcom,cci1@ac16000/qcom,cam-sensor1: failed to match any schema with compatible: ['qcom,cam-sensor']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: qcom,cam-sensor1 (qcom,cam-sensor): gpio-req-tbl-label: b'CAM_MCLK4CAMIF_RESET0' is not of type 'object', 'integer', 'array', 'boolean', 'null'

Fix:

  1. The gpio-req-tbl-label property appears to be missing proper string array formatting. In arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi:65-66, ensure the labels are properly separated:

    gpio-req-tbl-label = "CAM_MCLK4",
                         "CAMIF_RESET0";
    

    The error suggests they may be concatenated without proper null termination.

  2. The ranges property error indicates the parent qcom,cci1@ac16000 node expects child nodes to have address translation. This is likely a schema mismatch with the vendor camera binding expectations.

Reproduce locally:

make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/

❌ check-patch-compliance

Root cause: Both commits lack required subject prefix for the target branch

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd
Commit summary does not start with a required prefix

Checking commit: Update glymur-camera-sensor.dtsi
Commit summary does not start with a required prefix

Fix:

  1. Commit 1 already has QCLINUX: prefix but the checker still failed. This suggests the branch tech/overlay/dt may require a different prefix pattern. Check the branch-specific requirements in .github/workflows/ or kernel-checkers configuration.

  2. Commit 2 has a generic subject "Update glymur-camera-sensor.dtsi" which violates kernel commit message standards:

    • Use imperative mood
    • Be specific about what changed
    • Include subsystem prefix

    Suggested rewrite:

    QCLINUX: arm64: dts: qcom: glymur: Fix shared pinctrl gpio offset
    
    Change gpios-shared-pinctrl from phandle reference to numeric GPIO
    offset (760) to match the expected format for shared pinctrl
    configuration in the camera resource manager.
    
    Signed-off-by: Vishal Verma <vishverm@qti.qualcomm.com>
    

Reproduce locally:

# Check what prefixes are required for this branch
git log --oneline tech/overlay/dt | head -20

Verdict

3 blockers must be fixed before merge:

  1. dtb-check failure - Fix gpio-req-tbl-label formatting in the new camera sensor node
  2. check-patch-compliance - Rewrite commit 2 with proper subject and description
  3. checkpatch warning - Can be waived if this is vendor downstream code; otherwise add DT binding documentation

The dtb-check failure is the most critical as it indicates the device tree will not validate correctly at runtime.

Enable camera sensors og0va1b on the Glymur CRD platform.

Adds required DT updates to support sensor bring-up and
probe on Glymur crd board.

Signed-off-by: Vishal Verma <vishverm@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1415 — validate-patch

PR: #1415

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1415 - QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of camera sensor enablement
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Signed-off-by present and correct
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi Adds og0a1b sensor node, moves pinctrl to cam-res-mgr, clean changes

Verdict

Merge as-is — vendor-only DTS change with proper commit message structure and clean diff.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1415 — checker-log-analyzer

PR: #1415
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28367295216

Checker Result Summary
Checker Result Summary
checkpatch Undocumented DT compatible string warning
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Schema validation failures for qcom,cam-sensor1 node
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1415 - QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28367295216

Checker Result Summary
checkpatch Undocumented DT compatible string warning
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Schema validation failures for qcom,cam-sensor1 node
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

❌ checkpatch

Root cause: The compatible string "qcom,cam-sensor" used in the new camera sensor node is not documented in the devicetree bindings.

Failure details:

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#38: FILE: arch/arm64/boot/dts/qcom/glymur-camera-sensor.dtsi:44:
+		compatible = "qcom,cam-sensor";

297b94729abdf479bb5c63afd50732d2eb64bcf4 total: 0 errors, 1 warnings, 0 checks, 58 lines checked

Fix:

  1. Add a devicetree binding document for qcom,cam-sensor in Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml (or similar path)
  2. OR use an existing documented compatible string if this is a vendor-specific node that doesn't require upstream documentation

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git <base-commit>..<head-commit>

❌ dtb-check

Root cause: The new qcom,cam-sensor1 node fails DT schema validation because it doesn't match any registered schema and has property type mismatches.

Failure details:

arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: /soc@0/qcom,cci1@ac16000/qcom,cam-sensor1: failed to match any schema with compatible: ['qcom,cam-sensor']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: qcom,cci1@ac16000 (qcom,cci): qcom,cam-sensor1: 'ranges' is a required property

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/glymur-crd-camx.dtb: qcom,cam-sensor1 (qcom,cam-sensor): gpio-req-tbl-label: b'CAM_MCLK4\x00CAMIF_RESET0\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'

Fix:

  1. Primary issue: Create a proper DT binding schema for qcom,cam-sensor that defines all required and optional properties
  2. Missing property: Add ranges; property to the qcom,cam-sensor1 node if it's expected to be a bus node, or adjust the schema to not require it
  3. Property type issue: The gpio-req-tbl-label property appears to be a string array but the schema expects a different type - verify the correct property definition in the binding

Reproduce locally:

make O=out defconfig
make O=out CHECK_DTBS=y qcom/glymur-crd-camx.dtb

❌ check-patch-compliance

Root cause: The commit subject line uses QCLINUX: prefix which is not a recognized upstream or backport prefix.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Enable og0va1b camera sensor on glymur crd
Commit summary does not start with a required prefix

Fix:
Change the subject prefix from QCLINUX: to one of the accepted prefixes:

  • UPSTREAM: - for patches already merged in mainline Linux
  • FROMLIST: - for patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - for patches backported from a newer kernel version
  • Or remove the prefix entirely if this is original work for the Qualcomm tree

Example corrected subject:

arm64: dts: qcom: glymur: Enable og0va1b camera sensor on crd

Reproduce locally:

# Check if commit follows the required prefix convention
git log --oneline -1

Verdict

3 blockers must be fixed before merge:

  1. checkpatch warning - Document the qcom,cam-sensor compatible string or use an existing documented compatible
  2. dtb-check failures - Create proper DT binding schema and fix property definitions for the camera sensor node
  3. check-patch-compliance - Remove QCLINUX: prefix or replace with an accepted prefix (UPSTREAM:/FROMLIST:/BACKPORT:)

The dtb-check and checkpatch failures are related - both stem from the missing devicetree binding documentation for qcom,cam-sensor. Creating a proper binding schema will resolve both issues simultaneously.

@vishverm-qli

Copy link
Copy Markdown
Author

CRs-Fixed: 4590425

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/overlay/dt'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/overlay/dt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.