Make layout propagation fixed-point and broadcast-safe - #21956
Open
mcremon-meta wants to merge 1 commit into
Open
Make layout propagation fixed-point and broadcast-safe#21956mcremon-meta wants to merge 1 commit into
mcremon-meta wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21956
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 26a6b8e with merge base 3caaaca ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116683130. |
This PR needs a
|
Contributor
Author
|
@zingo can we get the right eyes on this please? |
Summary: Run view/permute propagation to a fixed point for every supported TOSA specification instead of conditionally disabling iterative propagation for one specification family. A layout transform may be element-order invariant at a reshape while the reshape output shape remains semantically significant to downstream broadcasting. Make permutation-sink termination conditional on downstream layout invariance, preserving the transform when another consumer depends on its logical axis placement. This allows all targets to use the same propagation algorithm while retaining conservative correctness checks around elementwise inputs, reshape sinks, and keep-dimension reductions. Differential Revision: D116683130
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D116683130
branch
from
August 20, 2026 03:47
af88110 to
26a6b8e
Compare
zingo
added
the
partner: arm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Run view/permute propagation to a fixed point for every supported TOSA specification instead of conditionally disabling iterative propagation for one specification family.
A layout transform may be element-order invariant at a reshape while the reshape output shape remains semantically significant to downstream broadcasting. Make permutation-sink termination conditional on downstream layout invariance, preserving the transform when another consumer depends on its logical axis placement.
This allows all targets to use the same propagation algorithm while retaining conservative correctness checks around elementwise inputs, reshape sinks, and keep-dimension reductions.
Differential Revision: D116683130
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani