Skip to content

gh-151693: Make the curses tests portable to other curses implementations#151729

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:curses-test-portability
Jun 19, 2026
Merged

gh-151693: Make the curses tests portable to other curses implementations#151729
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:curses-test-portability

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 19, 2026

Copy link
Copy Markdown
Member

Follow-up to GH-151694: make the new test_curses tests pass on curses implementations other than ncurses.

  • test_coordinate_errors only calls window.chgat() when it is available — it requires a curses providing wchgat().
  • test_pad no longer assumes a subpad shares the parent pad's character cells; X/Open Curses leaves that implementation-defined, so the test now writes to and reads from the subpad itself.

🤖 Generated with Claude Code

@serhiy-storchaka @claude
Make the curses tests portable to other curses implementations
026c94b 
Guard the chgat() check (chgat() needs wchgat()) and stop assuming a
subpad shares the parent pad's cells (implementation-defined in X/Open).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2026
Open
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 19, 2026
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) June 19, 2026 11:21
@serhiy-storchaka serhiy-storchaka merged commit 64fab74 into python:main Jun 19, 2026
60 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 64fab74bd7288bfa67cd7727452febdaafed4270 3.15

@miss-islington-app

miss-islington-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 64fab74bd7288bfa67cd7727452febdaafed4270 3.14

@miss-islington-app

miss-islington-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 64fab74bd7288bfa67cd7727452febdaafed4270 3.13

@bedevere-app

bedevere-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

GH-151730 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 19, 2026
@bedevere-app

bedevere-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

GH-151731 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2026
serhiy-storchaka added a commit that referenced this pull request Jun 19, 2026
@serhiy-storchaka @claude
[3.13] gh-151693: Make the curses tests portable to other curses impl…
cc7043d 
…ementations (GH-151729) (GH-151730)

Guard the chgat() check (chgat() needs wchgat()) and stop assuming a
subpad shares the parent pad's cells (implementation-defined in X/Open).
(cherry picked from commit 64fab74)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jun 19, 2026
@serhiy-storchaka @claude
[3.14] gh-151693: Make the curses tests portable to other curses impl…
8fff472 
…ementations (GH-151729) (GH-151731)

Guard the chgat() check (chgat() needs wchgat()) and stop assuming a
subpad shares the parent pad's cells (implementation-defined in X/Open).
(cherry picked from commit 64fab74)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@serhiy-storchaka serhiy-storchaka added needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 19, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

GH-151733 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serhiy-storchaka