Preserve original version strings in core metadata - #2385
Draft
aryansk wants to merge 1 commit into
Draft
Conversation
cjames23
requested changes
Aug 13, 2026
| _ = self.version | ||
| return cast(str, self._raw_version) | ||
|
|
||
| @property |
Member
There was a problem hiding this comment.
Why the wrapper function and why is self.version being assigned to a throwaway inside this function that does not require it at all. This looks like you did not review this AI generated code at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2384
Summary
Tests
This PR was prepared with AI assistance and the implementation and test results were reviewed locally.