Avoid retaining evaluate out arrays#560
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory-retention issue in NumExpr’s re_evaluate() caching by avoiding strong references to arrays provided via out= in the thread-local “last expression” cache, preventing large output buffers from being unintentionally pinned.
Changes:
- Cache
out=as aweakrefinvalidate()so the most recent output array isn’t kept alive solely by_numexpr_last. - Resolve the weak reference in
re_evaluate()to reuse liveout=arrays when still available. - Add regression tests covering both “doesn’t keep
outalive” and “reuses liveout”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RELEASE_NOTES.rst | Documents the behavioral change for out= retention in the re_evaluate cache. |
| numexpr/tests/test_numexpr.py | Adds tests asserting out= isn’t pinned and that re_evaluate() still reuses a live out. |
| numexpr/necompiler.py | Implements weakref-based caching for out= and resolves it during re_evaluate(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
LGTM. I had to disable providing free-threaded wheels for Python 3.13t, because NumPy already does that, so let's play the same game. Thanks @gaoflow ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558.
validate()cached theout=array directly in_numexpr_lastsore_evaluate()could reuse it. That kept the most recent output array alive even after the caller deleted their last reference.This stores a weak reference for cached
out=instead.re_evaluate()resolves it when called, so live output arrays are still reused, but released arrays are no longer pinned by the cache.Tests:
.venv/bin/python -m pytest numexpr/tests/test_numexpr.py -q.venv/bin/python -m pytest --pyargs numexpr -q.venv/bin/python -m compileall -q numexpr