(MODULES-11706) Add support for Puppet 9 - #440
Draft
shubhamshinde360 wants to merge 3 commits into
Draft
Conversation
Update Gemfile, Rakefile, CI workflow, and metadata.json to support the Puppet 9 (8.99.x) gem stream alongside Puppet 7/8. Gemfile changes: - Detect the Puppet 9 stream via PUPPET_GEM_VERSION and resolve gems from PUPPET_GEM_SOURCE (a CI secret) or the puppetcore source. - Use voxpupuli-puppet-lint-plugins 7.x and a temporary puppetlabs_spec_helper branch (MODULES-11700) that allows puppet-lint 5.x, required for Ruby 3.4+. - Point puppet_litmus at the main branch to pick up the --collection-platform-exclude flag (MODULES-11702). Rakefile changes: - Disable strict_indent, params_not_optional_with_undef, and exec_idempotency lint checks that are incompatible across the Puppet 8 and 9 lanes. CI workflow changes: - Exclude ubuntu-20.04 from the Puppet 9 acceptance matrix. metadata.json changes: - Extend puppet version_requirement to < 10.0.0. - Drop Ubuntu 18.04 from supported OS releases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Spec job in ci.yml was missing `secrets: "inherit"`, which meant the reusable workflow did not receive repo secrets like PUPPET_GEM_SOURCE. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
voxpupuli-puppet-lint-plugins7.x,puppetlabs_spec_helperfrom git main (MODULES-11700),puppet_litmusfrom git main (MODULES-11702), andPUPPET_GEM_SOURCE-based gem resolution.strict_indent,params_not_optional_with_undef, andexec_idempotencylint checks in the Rakefile that are incompatible across Puppet 8 and 9 lanes.ubuntu-20.04from the Puppet 9 acceptance matrix in the CI workflow.puppet version_requirementto< 10.0.0and drop Ubuntu 18.04 frommetadata.json.Test plan
PUPPET_GEM_VERSIONset to~> 8.99ubuntu-20.04is excluded only from the Puppet 9 acceptance matrix🤖 Generated with Claude Code