Skip to content

Content review: content/docs/iac/concepts/assets-archives.md - #20737

Merged
pulumi-bot merged 1 commit into
masterfrom
content-review/docs-iac-concepts-assets-archives
Aug 6, 2026
Merged

Content review: content/docs/iac/concepts/assets-archives.md#20737
pulumi-bot merged 1 commit into
masterfrom
content-review/docs-iac-concepts-assets-archives

Conversation

@pulumi-bot

@pulumi-bot pulumi-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Important

This PR is set to auto-merge (squash). Once it has an approving review and the required build check passes, GitHub will merge it automatically — approving this PR will merge it. To prevent that, disable auto-merge (or convert the PR back to a draft) before approving.

Why this page

  • Page: content/docs/iac/concepts/assets-archives.md/docs/iac/concepts/assets-archives/
  • Lane: priority
  • Strategic tier: 1 (no_retire: true)
  • Traffic: 767 monthly visits (period 2026-02-03 to 2026-08-03; source CLICKSTREAM.FCT_PAGEVIEWS)
  • Last reviewed: 2026-06-16 (attempts: 0)
  • Selection score: 33.4194

This section is composed deterministically from the selection queue; do not edit it.

Fixes applied

Claim / finding Authoritative source Correction
Readthrough orphaned-structure (L184): "The contents of the archive are read from a map of either Asset or [Archive](#archive…" readthrough coherence pass (in-page heading IDs) The two in-page links pointed at #asset and #archive, but the page's headings are ## Assets (L29) and ## Archives (L178), which Hugo renders as #assets and #archives. Both links were dead jumps; corrected to #assets and #archives.

Findings not applied

  • Claim (c13, L53): In Python, a RemoteAsset is constructed via pulumi.RemoteAsset("http://worldclockapi.com/api/json/est/now"). — Not applied: the verdict is about the illustrative endpoint (worldclockapi.com now returns HTTP 503), not the Pulumi API surface, which is correct. Picking a replacement example URL is an editorial choice with no authoritative correction, so it stays for a human.
  • Claim (c15, L62): the same dead worldclockapi.com example URL in the Go sample. — Not applied: same reason as c13 — the API surface is correct and the substitute URL would be invented, not sourced.
  • Claim (c19, L82): the same dead worldclockapi.com example URL in the Java sample. — Not applied: same reason as c13.
  • Claim (c21, L95): the same dead worldclockapi.com example URL in the YAML fn::remoteAsset sample. — Not applied: same reason as c13. All four (plus c11 and c17 below) are one underlying issue — a single example URL repeated across six language tabs — and should be changed together in one editorial pass.
  • Claim (c11): In TypeScript, a RemoteAsset is constructed via new pulumi.asset.RemoteAsset("http://worldclockapi.com/api/json/est/now"). — unverifiable — Not applied: unverifiable verdict, and the finding is about the dead example URL rather than the TypeScript API surface. Same underlying issue as c13/c15/c19/c21. (context: The claim's cited URL (used as an example argument to RemoteAsset, not as documentation source) currently returns HTTP 503 Service Unavailable. This is a code-…)
  • Claim (c17, L73): In C#, a RemoteAsset is constructed via new RemoteAsset("http://worldclockapi.com/api/json/est/now"). — Not applied: medium confidence, shifted framing, and again about the dead example endpoint rather than the C# constructor signature, which is correct. (context: The cited URL http://worldclockapi.com/api/json/est/now returns HTTP 503 Service Unavailable with an empty body, so it cannot substantiate the example endpoint…)
  • Claim (c32): In TypeScript, an AssetArchive is constructed via new pulumi.asset.AssetArchive({...}) taking a map of string keys to Asset or Archive values. — unverifiable — Not applied: unverifiable only because the cited source hint is contoso.com, Microsoft's reserved example domain used here deliberately as a placeholder. The TypeScript AssetArchive usage shown is correct; there is nothing to fix. (context: The cited source_hint URL (http://contoso.com/file.zip) is a placeholder/example domain that redirects to an unrelated Microsoft marketing page — it does not a…)
  • Claim (c34): In Python, an AssetArchive is constructed via pulumi.AssetArchive({...}) taking a dict of string keys to Asset or Archive values. — unverifiable — Not applied: same as c32 — contoso.com is an intentional placeholder, not a broken citation. The Python usage shown is correct. (context: The cited URL (http://contoso.com/file.zip) is a placeholder/example domain unrelated to Pulumi documentation; it resolves to an unrelated Microsoft page and p…)
  • Claim (c38): In C#, an AssetArchive is constructed via new AssetArchive(new Dictionary<string, string>{...}). — unverifiable — Not applied: same placeholder-domain artifact as c32/c34. Separately, the C# sample's Dictionary<string, string> type argument looks wrong for a map of assets, but confirming the correct generic parameter needs an SDK check, so it is flagged rather than guessed. (context: The cited URL "http://contoso.com/file.zip" is a placeholder example domain (contoso.com is Microsoft's fictional example domain) and redirects to Microsoft's …)
  • Claim (c51, L328-334): In Java, com.pulumi.aws.lambda.Function's builder accepts a .code(...) method that can be set to a fileArchive, alongside .role(...), .runtime(...), an… — framing drift (value accurate, meaning drifted) — Not applied: framing drift only — the Java sample uses FunctionArgs.builder(), which is correct; the claim extractor attributed the builder to Function. No page defect. (context: The doc's Java example shows com.pulumi.aws.lambda.FunctionArgs.builder() (not Function's own builder) providing .role(...), .runtime(...), `.handler(.…)
  • Vale filler (L27): Don't start a sentence with 'There are'. — Not applied: style nag without a deterministic_fix; rewriting a "There are three types of…" lead-in is a prose judgment, not a correction. (context: Don't start a sentence with 'There are'.)
  • Vale weasel word (L27): 'several' is a weasel word! — Not applied: style nag without a deterministic_fix. "several different concrete implementations" is accurate and rewriting it is a prose judgment. (context: 'several' is a weasel word!)
  • Vale filler (L31): Don't start a sentence with 'There are'. — Not applied: style nag without a deterministic_fix; rewriting a "There are three types of…" lead-in is a prose judgment, not a correction. (context: Don't start a sentence with 'There are'.)
  • Vale filler (L180): Don't start a sentence with 'There are'. — Not applied: style nag without a deterministic_fix; rewriting a "There are three types of…" lead-in is a prose judgment, not a correction. (context: Don't start a sentence with 'There are'.)

For the judgment-level items above, run /glow-up content/docs/iac/concepts/assets-archives.md.

Screenshot check

No images. The page source references no screenshots, diagrams, or other content images (only the generic shared meta_image card, if any), so there is nothing to verify. (Determined from the source; the screenshot pass was skipped.)

Rendered content

Skipped — the page source uses only render-safe chrome (choosable, chooser), so the rendered HTML and markdown carry no content beyond the source prose (nothing data-sourced or partial-included to fact-check). No make build or rendered pass required. (Determined from the source.)

Verification

  • make lint: ✅ make lint re-verified by the workflow on 250853dae1
  • Pre-step artifacts:
    • .verified-claims.json: 52 verdict(s); 5 contradicted/mismatch, 4 unverifiable
    • .vale-findings.json: 4 finding(s)
    • .readthrough-findings.json: ran=True, 1 finding(s)
    • .frontmatter-validation.json: 1 file(s); 0 alias collision(s)

Automated existing-content review.

Co-Authored-By: Claude <noreply@anthropic.com>
@pulumi-bot
pulumi-bot enabled auto-merge (squash) August 6, 2026 15:02
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:docs PR touches technical docs review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-08-06T15:04:54Z

Tip

Summary: This is a one-line correction to the Assets and Archives IaC concepts page: the two in-page anchor links in the AssetArchive bullet are changed from #asset/#archive to #assets/#archives. The wrongness that would block a reader here is a dead in-page link — a reader clicking through from the AssetArchive description to learn what an Asset or Archive is would land nowhere. Both new targets match real headings on the page (## Assets at L29, ## Archives at L178), and sibling pages that deep-link into this page already use the same #assets anchor, so the change is consistent site-wide. Passes run: frontmatter sweep, in-page anchor/link integrity, external claim verification (2 of 2 claims verified), and a cross-sibling read of the pages that link into this one's anchors. No code examples, no editorial-balance pass (not a blog post), and no Hugo build errors.

Review confidence:

Dimension Level Notes
mechanics HIGH Both anchor targets confirmed against headings on the same page.
facts HIGH
cross-sibling consistency HIGH Checked every page that deep-links into this page's anchors; all already use #assets.
Investigation log
  • Cross-sibling reads: 3 of 11 siblings
  • External claim verification: 2 of 2 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 2 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: ran on body + meta_desc
  • Temporal-trigger sweep: not run (no trigger words)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

2 claims extracted · 2 verified · 0 unverifiable · 0 contradicted
  • L184 in content/docs/iac/concepts/assets-archives.md "The Archive reference within the AssetArchive description links to an anchor named #archives on the page." → ✅ verified (evidence: Line 184 reads: AssetArchive: The contents of the archive are read from a map of either Asset or Archive objects... The link target #archives matches the ## Archives heading on the same page (line 178), co…; source: repo:content/docs/iac/concepts/assets-archives.md)
  • L184 in content/docs/iac/concepts/assets-archives.md "The AssetArchive type's contents are read from a map of either Asset or Archive objects, with one file or folder respectively per entry in the map." → ✅ verified (evidence: The doc itself states: "AssetArchive: The contents of the archive are read from a map of either Asset or Archive objects, one file or folder respectively per entry in the map." This is corroborated by the code examples immediately be…; source: repo:content/docs/iac/concepts/assets-archives.md L184; gh search code --owner pulumi "class AssetArchive")

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-08-06T15:04:54Z — Verified the corrected #assets/#archives in-page anchors match real headings and match how sibling pages link in; no blocking findings. (250853d)

  • Refresh this review — comment @claude #update-review. Say what you fixed, or which finding you dispute and why; both work in the same mention.
  • Ask for anything else — comment @claude with no hashtag (questions, one-off fixes). Leaves this review untouched.

Important

Please don't hide, resolve, or delete this comment! It breaks things!

📖 How pre-merge review works — the full lifecycle, short-circuits, and escape hatches.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Aug 6, 2026
@pulumi-bot

Copy link
Copy Markdown
Collaborator Author

@CamSoper CamSoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated rubber stamp approval applied :shipit: -- What is this?


Generated by Claude Code

@pulumi-bot
pulumi-bot merged commit 26e36b5 into master Aug 6, 2026
9 checks passed
@pulumi-bot
pulumi-bot deleted the content-review/docs-iac-concepts-assets-archives branch August 6, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:docs PR touches technical docs review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants