Skip to content

Replace the animated docs link underline with a plain hover underline - #20730

Open
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/remove-docs-hover-underline
Open

Replace the animated docs link underline with a plain hover underline#20730
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/remove-docs-hover-underline

Conversation

@jeffmerrick

Copy link
Copy Markdown
Contributor

Proposed changes

Docs content links (section.docs-content p a / ul li a[href]) used a two-layer linear-gradient background animated via background-size to sweep a gray underline in from the left on hover. This replaces that effect with a standard text-decoration: underline and a 2px text-underline-offset, and drops the padding-bottom that reserved space for the animated rule. Link colors are unchanged in both light and dark mode — the dark-mode override in _docs-theme.scss only sets color, so it carries through untouched.

Unreleased product version (optional)

N/A

Related issues (optional)

N/A

Docs content links used a two-layer gradient background animated via
background-size to sweep a gray underline in from the left on hover.
Swap it for a standard text-decoration underline with a 2px offset.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jeffmerrick
jeffmerrick marked this pull request as ready for review August 5, 2026 21:16
@jeffmerrick
jeffmerrick requested a review from cnunciato August 5, 2026 21:16
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-08-05T21:18:39Z

Tip

Summary: This is a styling-only change to the docs theme: theme/src/scss/docs/_docs-main.scss drops the animated gradient "wipe" underline on body links in section.docs-content (the layered linear-gradient backgrounds, the background-size transition, and the padding-bottom: 0.2rem spacer that made room for it) and replaces the hover treatment with a plain text-decoration: underline plus text-underline-offset: 2px. There is no prose, frontmatter, or code-example content in the diff, so the failure mode worth checking is visual rather than factual — a link affordance that disappears entirely, or a hover color that stops being legible in dark mode. Both check out: the link's base color still comes from var(--docs-link, …), and theme/src/scss/docs/_docs-theme.scss already overrides section.docs-content p a:not(.btn):hover / ul li a[href]:hover to var(--color-violet-200) under data-theme="dark", so the hover state stays legible in both modes and every removed declaration was in service of the deleted animation. Passes run: diff read, a dark-mode token trace through _docs-theme.scss, Vale prose lint (no content files in scope), and the Hugo build / link preflight (skipped — no templating or content paths touched).

Review confidence:

Dimension Level Notes
mechanics HIGH
styling MEDIUM Assessed by reading the SCSS and its dark-mode overrides; CI can't render the page, so the visual result itself is unverified.
Investigation log
  • Cross-sibling reads: not run (not in a templated section)
  • External claim verification: not run (no claims in this diff)
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: not run (no frontmatter in diff)
  • Temporal-trigger sweep: not run (no trigger words)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

No verifiable claims extracted from this diff.

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-08-05T21:18:39Z — Reviewed the docs link-underline SCSS change; no findings — the removed declarations all belonged to the deleted animation, and dark-mode hover is already handled in _docs-theme.scss (654e8e8)

  • Refresh this review — comment @claude #update-review. Say what you fixed, or which finding you dispute and why; both work in the same mention.
  • Ask for anything else — comment @claude with no hashtag (questions, one-off fixes). Leaves this review untouched.

Important

Please don't hide, resolve, or delete this comment! It breaks things!

📖 How pre-merge review works — the full lifecycle, short-circuits, and escape hatches.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Aug 5, 2026
@pulumi-bot

Copy link
Copy Markdown
Collaborator

@pulumi-bot

Copy link
Copy Markdown
Collaborator

Lighthouse Performance Report

Commit: 654e8e8 | Metric definitions

Page Device Score FCP LCP TBT CLS SI
Homepage Mobile 🔴 45 7.9s 14.3s 460ms 0.000 8.7s
Homepage Desktop 🟡 80 0.7s 2.2s 129ms 0.048 2.6s
Install Pulumi Mobile 🟡 57 6.0s 9.8s 86ms 0.053 7.5s
Install Pulumi Desktop 🟡 83 1.2s 2.6s 0ms 0.015 1.2s
AWS Get Started Mobile 🟡 57 7.8s 16.2s 20ms 0.000 7.8s
AWS Get Started Desktop 🟡 82 1.2s 2.6s 0ms 0.050 1.2s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants