Rewrite in N-API#3
Open
savetheclocktower wants to merge 18 commits into
Open
Conversation
Author
|
OK, after lots of wailing and grinding of teeth I've got CI passing on all three platforms. This should obviate the need for #2 or #1 — all N-API modules are context-aware, and I'm imagining there will be fewer of those version-check fixes needed with N-API. And if we land this we should be able to bump the version we use in the |
This was referenced Jun 19, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs updates to build against Node 22 (and Electron 32.3.3 because of its newer V8 version), so we might as well take this opportunity to migrate to N-API.
Specs are still in CoffeeScript, and I plan to address that next… but I wasn't going to decaf the specs until after this PR so we can more easily prove lack of regressions.