build: Run the desc64 register generation once under make -j - #220
Open
DanielKellerM wants to merge 1 commit into
Open
build: Run the desc64 register generation once under make -j#220DanielKellerM wants to merge 1 commit into
DanielKellerM wants to merge 1 commit into
Conversation
The three desc64 outputs were targets of one plain multi-target rule, so GNU make ran the recipe once per target and concurrent runs clobbered each other's files. Hang reg_pkg and addrmap_pkg off reg_top so the recipe runs once (grouped targets need make 4.3; this form is portable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three desc64 register outputs were the targets of one plain multi-target rule, so GNU make ran the recipe once per target and, under
make -j, three concurrentpeakrdlinvocations clobbered each other's outputs (seen in cheshire's CI after bumping to 0.7.0 — pulp-platform/cheshire#294 had to serialize iDMA generation behind aflock). Make the two siblings depend onreg_topso the recipe runs exactly once; grouped targets (&:) need make 4.3, this form is portable. Verified:make -j8runspeakrdl regblockonce, a second invocation is a no-op,idma_hw_allunchanged.