Refactor hci_core_{source,sink}_v2 as thin wrappers - #86
Open
FrancescoConti wants to merge 1 commit into
Open
Conversation
This commit refactors hci_core_{source,sink}_v2, which introduced
ready/valid job queues, as thin wrappers around "traditional"
hci_core_{source,sink}.
Most (if not all) downstream HWPEs use non-v2 streamers, which
still receive significant updates and improvements. On the other
hand, v2 streamers have been left untouched and are only lightly
tested.
Moving the v2 streamers to thin wrappers has the primary advantage
that any code duplication (and divergence) is removed.
Eventually, non-v2 streamers may be deprecated and in that case
their functionality may be reintegrated in the v2 streamers, but
this can happen only if most downstream HWPEs migrate to v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors hci_core_{source,sink}v2, which introduced ready/valid job queues, as thin wrappers around "traditional" hci_core{source,sink}.
Most (if not all) downstream HWPEs use non-v2 streamers, which still receive significant updates and improvements. On the other hand, v2 streamers have been left untouched and are only lightly tested.
Moving the v2 streamers to thin wrappers has the primary advantage that any code duplication (and divergence) is removed. Eventually, non-v2 streamers may be deprecated and in that case their functionality may be reintegrated in the v2 streamers, but this can happen only if most downstream HWPEs migrate to v2.