fix: support Bitkit local wallet tests - #11
Open
ben-kaufman wants to merge 6 commits into
Open
Conversation
This was referenced Aug 4, 2026
ben-kaufman
marked this pull request as ready for review
August 4, 2026 18:49
ben-kaufman
marked this pull request as draft
August 4, 2026 19:21
ben-kaufman
marked this pull request as ready for review
August 5, 2026 11:44
ovitrif
requested changes
Aug 5, 2026
ovitrif
left a comment
There was a problem hiding this comment.
One blocking issue and one non-blocking issue remain:
- Creator-demo boots with
--external-walletand publishes the creator profile only after wallet approval, but reader-demo still binds once from.local/creator-public/profile.jsonand can run against a stale prior identity or terminal-fail while the profile is missing. /api/demo-auth/startstill returns a recovery-file authenticate command under--external-wallet, so the creator page can steer operators onto a local recovery identity instead of the Bitkit wallet.
ben-kaufman
force-pushed
the
codex/bitkit-local-e2e-fixes
branch
from
August 6, 2026 18:44
3bb5cb9 to
8c5dd3f
Compare
Author
|
@jvsena42 could you please review the current head? The external-wallet identity/profile fixes have been exercised in the clean iOS and Android Locks → Paykit → Bitkit E2E flow, and all prior review threads are resolved. |
ben-kaufman
force-pushed
the
codex/bitkit-local-e2e-fixes
branch
from
August 6, 2026 19:45
8c5dd3f to
be5d31e
Compare
ben-kaufman
force-pushed
the
codex/bitkit-local-e2e-fixes
branch
from
August 6, 2026 19:50
be5d31e to
1a5f97c
Compare
Author
ovitrif
requested changes
Aug 6, 2026
ovitrif
left a comment
There was a problem hiding this comment.
Thanks for addressing the recovery-auth command. One blocking issue remains: the waiting_for_creator gate still waits on the private content-creator profile path, so Compose external-wallet never observes the published creator-public profile and the reader never prepares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is intentionally stacked on #10 because it hardens and completes that demo's app-wallet test path.
Contract and risk impact
Verification
npm --prefix examples/js-sdk run checknpm --prefix examples/js-sdk run validate:paykit-composenode examples/js-sdk/scripts/smoke-paykit-compose.mjsdocker compose -f compose.paykit-local-demo.yaml build creator-demo8080to18080waiting, Homegate returned a valid signup response, creator preflight passed, and Fulcrum answered an Electrum version requestDocumentation
Updated
examples/js-sdk/README.mdfor the external-wallet flow, local service endpoints, and runtime reset.Checklist