Skip to content

refactor(bayn): enforce strict Effect diagnostics - #13617

Merged
gregkonush merged 1 commit into
codex/bayn-tsgo-unchecked-indexesfrom
codex/bayn-effect-tsgo-strict-diagnostics
Aug 10, 2026
Merged

refactor(bayn): enforce strict Effect diagnostics#13617
gregkonush merged 1 commit into
codex/bayn-tsgo-unchecked-indexesfrom
codex/bayn-effect-tsgo-strict-diagnostics

Conversation

@gregkonush

@gregkonush gregkonush commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • makes every default Effect TSGo error, warning, and suggestion blocking in both the full and production profiles, with a dedicated clean diagnostics --strict result
  • enables the off-by-default production safety rules for strict boolean conditions, unsafe Effect channel assertions, and Layer provisioning outside explicit boundaries
  • applies the documented Effect refactors: yieldable errors, tagged structs, direct Effects instead of zero-argument Effect wrappers, and simplified pipelines
  • captures WriterFence when lifecycle Layers are built so the public capital-grant service exposes only domain operations and no interpreter requirement
  • documents only real dynamic subprogram and application Layer boundaries; value-only Layers are identified explicitly rather than hidden behind another DI abstraction
  • retains narrow documented suppressions only where replacing typed undefined with Effect.void would change the public success type

Related Issues

None

Testing

  • bun --cwd=services/bayn run tsc
  • services/bayn/node_modules/@effect/tsgo/dist/effect-tsgo.js diagnostics --strict --project services/bayn/tsconfig.production.json --format text (341 files, 0 findings)
  • bun --cwd=services/bayn run lint
  • bun --cwd=services/bayn run lint:oxlint:type (465 files, 0 findings)
  • bun --cwd=services/bayn test (1,054 pass, 160 environment-gated PostgreSQL skips, 0 fail)
  • bun test services/bayn/src/execution/runtime-program.test.ts services/bayn/src/composition.test.ts services/bayn/src/forward-performance/program.test.ts services/bayn/src/observe-composition.test.ts (77 pass, 0 fail)
  • bun --cwd=services/bayn run test:postgres (0 fail; integration cases skipped locally because no test database URL is configured)
  • bun --cwd=services/bayn run build (793 modules)

Breaking Changes

None

Checklist

  • Testing section documents the exact validation performed (or N/A with justification).
  • Screenshots and Breaking Changes sections are handled appropriately (removed or filled in).
  • Documentation, release notes, and follow-ups are updated or tracked.

@gregkonush
gregkonush force-pushed the codex/bayn-effect-tsgo-strict-diagnostics branch 2 times, most recently from 4602f95 to efedea4 Compare August 10, 2026 03:08
@gregkonush

Copy link
Copy Markdown
Member Author

:shipit:

@gregkonush
gregkonush force-pushed the codex/bayn-effect-tsgo-strict-diagnostics branch from efedea4 to 3e06d0a Compare August 10, 2026 03:34
@gregkonush
gregkonush merged commit f0f34b7 into main Aug 10, 2026
16 checks passed
@gregkonush
gregkonush deleted the codex/bayn-effect-tsgo-strict-diagnostics branch August 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant