Skip to content

Fail loudly when a probe is not staged #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 1 commit into from
Aug 2, 2026
Merged

Fail loudly when a probe is not staged #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions scripts/test-rng-hygiene.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,23 @@ run_probe() {
return
fi

# Both that the tree is populated AND that this probe is in it. The git

# errors above are discarded, so a failed `git add` would otherwise leave

# the guard scanning a probe-free tree and the case judged on a file it

# never saw.

if ! GIT_INDEX_FILE="$TMPDIR_T/index" git ls-files --error-unmatch "$name" >/dev/null 2>&1; then

echo " HARNESS BROKEN: $name was not staged; the guard would never see it"

fails=$((fails + 1)); rm -f "$name"; PROBE=""; return

fi


local rc=0 out
out=$(GIT_INDEX_FILE="$TMPDIR_T/index" "$GUARD" 2>&1) || rc=$?

Expand Down
Loading